Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jdt-core-dev] Re: [platform-releng-dev] Issue in JDT/Core

Martin, please do not release any further change until the issue you
mention is also resolved.
Removing the assert is not a good way, if the assert makes sense there.



                                                                           
             Martin                                                        
             Aeschlimann/Zuric                                             
             h/IBM@IBMCH                                                To 
             Sent by:                  jdt-core-dev@xxxxxxxxxxx            
             jdt-core-dev-boun                                          cc 
             ces@xxxxxxxxxxx                                               
                                                                   Subject 
                                       [jdt-core-dev] Re:                  
             04/07/2005 10:09          [platform-releng-dev] Issue in      
             AM                        JDT/Core                            
                                                                           
                                                                           
             Please respond to                                             
             "Eclipse JDT Core                                             
             developers list."                                             
                                                                           
                                                                           





Sorry to everybody. I prepared a fix, ran all the test but got distracted
and forgot to release.

The Assertion is in fact correct and points to a problem in some other
code: JavaCore.getOptions at this point returns a map that contains on 5
entries.
I commented the assert out, but it would be good if somebody could have a
look at that.
bug is https://bugs.eclipse.org/bugs/show_bug.cgi?id=90446

Martin


                                                                           
 Philippe P Mulet/France/IBM@IBMFR                                         
 Sent by:                                                                  
 platform-releng-dev-bounces@xxxxxxxxxxx                                To 
                                                        jdt-core-dev@eclip 
                                                        se.org             
 07.04.2005 09:20                                                       cc 
                                                                           
                                                                   Subject 
               Please respond to                        [platform-releng-d 
  "Eclipse platform release engineering list."          ev] Issue in       
       <platform-releng-dev@xxxxxxxxxxx>                JDT/Core           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           





I caught last night a bogus change in DOM AST rewriter, which would have
caused 111 failures in our nightly tests.
I reverted the offending code to last integration state, but missed one
reference from JUnit tests.

So, we should expect one compile error in one of our test suite. It has
been fixed now in HEAD.

JDT/Core committers: our rule is: NO change is good if ANY test fails, even
worse when heading back home.

_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev
_______________________________________________
jdt-core-dev mailing list
jdt-core-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/jdt-core-dev




Back to the top