Re: [jdt-core-dev] CompletionRequestor.accept

[Philippe P Mulet <philippe_mulet@xxxxxxxxxx>]

This would allow clients to lazily ask questions to proposals as long as
the completion dialog remains open (expensive computations could be
performed on demand only).



                                                                           
             David                                                         
             Audel/France/IBM@                                             
             IBMFR                                                      To 
             Sent by:                  jdt-core-dev@xxxxxxxxxxx            
             jdt-core-dev-admi                                          cc 
             n@xxxxxxxxxxx                                                 
                                                                   Subject 
                                       Re: [jdt-core-dev]                  
             02/08/2005 11:33          CompletionRequestor.accept          
             AM                                                            
                                                                           
                                                                           
             Please respond to                                             
               jdt-core-dev                                                
                                                                           
                                                                           




The javadoc seems to suggest the behaviors that you describe, but the
validity of a CompletionProposal is longer.
The proposal object is valid as long as there is no change inside the
workspace.
In fact a CompletionProposal is valid during the call of
ICodeAssist#codeComplete(...) and just after.

Perhaps the javadoc can be improved.

"The proposal object passed is only valid for the duration of this call;
implementors must not hang on to these objects."

could be replaced by

"The proposal object passed is only valid for the duration of the
completion operation"

David

Monday, February 07, 2005 6:47 PM
To: jdt-core-dev@xxxxxxxxxxx
cc:
From: Tom Eicher <eclipse@xxxxxxxxxxxxxxx>
Subject: [jdt-core-dev] CompletionRequestor.accept



hi all,

The javadoc for CompletionRequestor.accept states that

"The proposal object passed is only valid for the duration of this call;
implementors must not hang on to these objects."


I assume this means the following - please clarify:

1) the passed instance of CompletionProposal is only valid during the
'accept' call (as opposed to during the entire code completion session
between beingReporting - endReporting).

2) the values (char arrays) returned by the CompletionProposal instance'
method are not covered by this limitation - the arrays can be stored for
the completion session given that they are not modified.

Is this correct? Thanks for clearing this up
-tom


_______________________________________________
jdt-core-dev mailing list
jdt-core-dev@xxxxxxxxxxx
 http://dev.eclipse.org/mailman/listinfo/jdt-core-dev

_______________________________________________
jdt-core-dev mailing list
jdt-core-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/jdt-core-dev