Re: [january-dev] Is master on github properly protected?

[<Matt.Gerring@xxxxxxxxxxxxx>]

Master branch is not properly protected Peter. You or Jonah as leads need to ask webmaster@xxxxxxxxxxx to put settings right I think.

 

Something like this after adding master as a protected branch:

 

Branch protection for master

Protect this branchDisables force-pushes to this branch and prevents it from being deleted.

Require pull request reviews before mergingWhen enabled, all commits must be made to a non-protected branch and submitted via a pull request with at least one approved review and no changes requested before it can be merged into master.

Include administratorsEnforce review requirements for repository administrators.

Require status checks to pass before mergingChoose which status checks must pass before branches can be merged into master. When enabled, commits must first be pushed to another branch, then merged or pushed directly to master after status checks have passed.

Include administratorsEnforce required status checks for repository administrators.

Require branches to be up to date before mergingThis ensures the branch has been tested with the latest code on master.

Status checks found in the last week for this repository

 continuous-integration/travis-ciRequired

 ip-validationRequired

 sonarqubeRequired

Restrict who can push to this branchSpecify people or teams allowed to push to this branch. Required status checks will still prevent these people from merging if the checks fail.

 

 

Matt

 

From: january-dev-bounces@xxxxxxxxxxx [mailto:january-dev-bounces@xxxxxxxxxxx] On Behalf Of Peter.Chang@xxxxxxxxxxxxx
Sent: 03 March 2017 16:55
To: january-dev@xxxxxxxxxxx
Subject: [january-dev] Is master on github properly protected?

 

Dear all,

 

I managed accidentally to commit directly onto master with https://github.com/eclipse/january/commit/df31fb65c950a8bd7002b64d0ca4a79d2e8d8e03 and https://github.com/eclipse/january/commit/a1654ca7d101a3e4c8ed943f8fad6259d3eaec25 from a local branch of mine. Should this be possible?

 

Regards,

Peter

 

 

-- 

This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
 

 

-- 

This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom