[imp-dev] Anyone using MarkerCreatorWithBatching.{page, BUILDER

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

[imp-dev] Anyone using MarkerCreatorWithBatching.{page, BUILDER_ID, PROBLEM_MARKER_ID} ?

From: "Robert M. Fuhrer" <rfuhrer@xxxxxxxxxxxxxx>
Date: Tue, 6 Apr 2010 16:48:03 -0400
Delivered-to: imp-dev@xxxxxxxxxxx
List-archive: <https://dev.eclipse.org/mailman/private/imp-dev>
List-help: <mailto:imp-dev-request@eclipse.org?subject=help>
List-subscribe: <https://dev.eclipse.org/mailman/listinfo/imp-dev>, <mailto:imp-dev-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://dev.eclipse.org/mailman/listinfo/imp-dev>, <mailto:imp-dev-request@eclipse.org?subject=unsubscribe>

Hi All,

Is anyone setting or even referencing these fields?

The 'page' field is unused in the class itself, and I suspect that it's globally unused as well.

The two ID fields can, and almost certainly should be, set via the constructor. In fact, I can't see why they shouldn't be private (or perhaps protected) and final.

--
Cheers,
-- Bob
--------------------------------
Robert M. Fuhrer
Research Staff Member
Programming Technologies Dept.
IBM T.J. Watson Research Center

IMP Team Lead (http://www.eclipse.org/imp)
X10: Productivity for High-Performance Parallel Programming (http://x10-lang.org)

Prev by Date: Re: [imp-dev] Small API change needed to improve performance of message/annotation handling
Next by Date: [imp-dev] Branching in SVN to move forward with new API
Previous by thread: [imp-dev] Small API change needed to improve performance of message/annotation handling
Next by thread: [imp-dev] Branching in SVN to move forward with new API
Index(es):
- Date
- Thread

Breadcrumbs