[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [imp-dev] API changes to TypeFactory?
|
Oh, and not to mention that the changes also caused compile errors
in org.eclipse.imp.java.core ...
Without poking around in the implementations of TypeStore,
TypeFactory and others, I don't even know what is the intended
design of the new TypeStores, so I can't tell how to fix the problems
the changes introduced.
On Feb 22, 2009, at 11:33 AM, Robert M. Fuhrer wrote:
Hi Jurgen,
The changes you made look reasonable in principle (separating out
the type dictionary from the TypeFactory), but I think these kind of
changes should be discussed on the mailing list first.
In particular, I see that the AnalysisManager is now broken - had I
not happened to look at the code while synching with the repo, I
wouldn't know about the bogus use of "new TypeStore()" (marked
by a TODO), which, although it compiles, would silently fail to find
types mentioned in an analysis engine's type descriptors (I think).
That sort of silent breakage is confusing and could be hard to
diagnose...
Cheers,
- Bob
