[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [imp-dev] LanguageActionsContributor stuff needs committing
|
I've committed the stuff, and updated some implementations but not
all. The eclipse svn has not been
responding this half hour. Need to fly now, but I can do more tomorrow morning.
Cheers,
Jurgen
On Wed, Jun 11, 2008 at 4:36 PM, Robert M. Fuhrer
<rfuhrer@xxxxxxxxxxxxxx> wrote:
> Oh, so rather than explicitly adding the implementations of the new
> interface
> methods, you can just adopt the default ones from the base class. That
> wasn't clear to me.
>
> On Jun 11, 2008, at 10:13 AM, Jurgen Vinju wrote:
>
>> The Default implementation is an empty one, because you can choose not
>> to add stuff
>> to the toolbar, but add stuff to the menubar. So, instead of having an
>> extension for every
>> kind of addition, the additions are grouped into one Contributor
>> interface. I copied this
>> design from Eclipse. It's like a listener interface with lot's of
>> methods you don't need to implement,
>> so there is a default empty one.
>>
>> I.o.w. they can just implement the relevant interface, extending the
>> Default one is just more convenient.
>>
>> Cheers,
>>
>> Jurgen
>>
>> On Wed, Jun 11, 2008 at 3:42 PM, Robert M. Fuhrer
>> <rfuhrer@xxxxxxxxxxxxxx> wrote:
>>>
>>> It certainly looks a tad suspicious that implementations can't just
>>> implement
>>> the relevant interface. Is there a good reason for this?
>>>
>>> On Jun 11, 2008, at 5:52 AM, Jurgen Vinju wrote:
>>>
>>>> Hi guys,
>>>>
>>>> I'm dying to commit my code to imp.runtime. Can I do that today?
>>>> People here really want to use the new features.
>>>>
>>>> Remember, after the commit all implementations of
>>>> ILanguageActionContributor will break in a small way, they can be
>>>> fixed by changing:
>>>> "implements ILanguageActionContributor" to "extends
>>>> DefaultLanguageActionContributor".
>>>>
>>>> Cheers,
>>>>
>>>> Jurgen
>>>> _______________________________________________
>>>> imp-dev mailing list
>>>> imp-dev@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/imp-dev
>>>
>>> Cheers,
>>> - Bob
>>>
>>> _______________________________________________
>>> imp-dev mailing list
>>> imp-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/imp-dev
>>>
>> _______________________________________________
>> imp-dev mailing list
>> imp-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/imp-dev
>
> Cheers,
> - Bob
>
> _______________________________________________
> imp-dev mailing list
> imp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/imp-dev
>
