[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [hyades-dev] Committer Approval Requested for 3.0.1.1 Defect Fix - Bugzilla 76170



I am, by no means, a usability expert and will trust their advice this is a
serious issue.  Are there any automated GUI tests which will break?  This
is a behavioural change in the UI and may have impact.  I do not believe
there are any, but I want to make sure.  Providing there are not, I vote
yes.



Richard K. Duggan
Problem Determination Enablement
IBM Toronto Laboratory
External: 905-413-2396
Internal: 969-2396



                                                                           
             Joseph P Toomey                                               
             <jptoomey@xxxxxxx                                             
             com>                                                       To 
             Sent by:                  hyades-dev@xxxxxxxxxxx              
             hyades-dev-admin@                                          cc 
             eclipse.org               hyades-dev@xxxxxxxxxxx,             
                                       hyades-dev-admin@xxxxxxxxxxx        
                                                                   Subject 
             10/13/2004 02:21          Re: [hyades-dev] Committer Approval 
             PM                        Requested for 3.0.1.1 Defect Fix  - 
                                       Bugzilla 76170                      
                                                                           
             Please respond to                                             
                hyades-dev                                                 
                                                                           
                                                                           
                                                                           





Given the necessity of this fix for the consuming product and the low risk
associated with the change, I vote yes.

Thanks,
--Joe

Joe Toomey
Senior Software Engineer
Rational Software
IBM Software Group
tel: (781) 676-7668
fax: (781) 676-7640
                                                                           
 Kent D                                                                    
 Siefkes/Raleigh/IBM@IBMU                                                  
 S                                                                      To 
 Sent by:                                hyades-dev@xxxxxxxxxxx            
 hyades-dev-admin@eclipse                                               cc 
 .org                                                                      
                                                                   Subject 
                                         [hyades-dev] Committer Approval   
 10/13/2004 02:11 PM                     Requested for 3.0.1.1 Defect Fix  
                                         -  Bugzilla 76170                 
                                                                           
     Please respond to                                                     
  hyades-dev@xxxxxxxxxxx                                                   
                                                                           
                                                                           
                                                                           
                                                                           





Please find below a stop-ship defect that has been approved today by IES
CCB to be included in IES 3.0.1.1. The defect has been reviewed, tested by
producer and consumer, very low risk and limited in scope to the http proxy
recorder, and involves no-PII.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=76170

The description follows:

When Recorder Control View is opened for the first time, if the
TestPerspective is not opened, it is created & set active.

This view should be created in the current perspective, whatever that is.

This is a critical fix because it prevents any vendors from using the
recorder
in their own perspectives.  Also, forced switching of perspectives is bad
Eclipse behavior.

The fix is in one file, shown below:

RecorderControlView.java

li 140 - getActivePage() method removed (method is no longer called)

li 164 - getInstance()
<                                IWorkbenchPage page = window.
getActivePage();
>                                IWorkbenchPage page = getActivePage();

I'm asking for Hyades committer approval for this defect fix.  No response
within 6 hours indicates silent approval.  Sorry for the urgency, but IES
requires a drop by tonight for inclusion in an additional 3.0.1.1 build
tomorrow morning.

The above fix has already been made on the head, and will be checked into
3.0.1.1 so that a build can be tested.  If approved, and testing uncovers
no problems,  the fix/build will be included in Friday's  IES 3.0.1.1
build.

Thanks,
Kent
ForwardSourceID:NT0001C72E