[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[hudson-dev] testMissingWorkspaceGives200 in hudson-test-harness
- From: Stuart McCulloch <mcculls@xxxxxxxxx>
- Date: Thu, 18 Aug 2011 02:52:57 +0100
- Delivered-to: email@example.com
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:content-type:content-transfer-encoding:subject:date:message-id :to:mime-version:x-mailer; bh=ZaFE2cHh6LVPkMQwbzr3S1XJkDEBBg0VENyVNeLQJl4=; b=Cmr5sylwPrpDHXoDstxqnnBgAtFq1yrhsvqoAMLQGZDuahDGWRRL81UV7mks2Nb1Fp BNJINcNYDoi3mr2ocUWLoWhjojGv2H0HdTR3qvNUEuVoX8Ijq46DjIzY39HiFI7xshKQ At3HFw/oCbbx0T/hbexlfYTq94QtNZVqRy/9Y=
I tried running the hudson-test-harness against 2.1.1-SNAPSHOT (currently its parent is still set to 2.1.0-SNAPSHOT) and get one failure:
testMissingWorkspaceGives200(hudson.model.AbstractProjectTest) Time elapsed: 9.796 sec <<< FAILURE!
junit.framework.AssertionFailedError: expected:<200> but was:<404>
Looking at the recent changes to AbstractProjectTest I see the following:
Author: akozak <antkozak@xxxxxxxxx>
Date: Fri Aug 5 11:25:21 2011 +0300
Updated broken test, it was broken with HUDSON-8950 fix.
Which changed the test to expect a status result of 200 instead of 404 when there's an attempt to access a file from a missing workspace.
But HUDSON-8950 is supposed to fix the missing workspace request to return 404 instead of 200 (which it appears to do, at least for me).
So is the test out of step, or is the fix for HUDSON-8950 incorrect? Should it expect 404 or 200?