[higgins-dev] updates to util.saml and util.saml.test

[Markus Sabadello <markus.sabadello@xxxxxxxxx>]

Hello list,

I have committed contributions by Anders Domeij of Logica (logica.com) according to these bugzilla entries:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=295042 

https://bugs.eclipse.org/bugs/show_bug.cgi?id=295045

The updates include:
- A cleaner separation of SAML 1 and SAML 2 classes
- Fixed and added unit tests which now run without failures
- Added implementation of previously unsupported SAML elements, such as LogoutReqest and LogoutRequestResponse

I have updated our test deployment of the SAML2 IdP at http://graceland.parityinc.net/saml2idp-test/ with the new code and it still runs fine. If someone else's code also depends on util.saml, you may want to test it, but I don't expect any problems.

Thanks a lot Anders!

Markus

On Fri, Nov 13, 2009 at 4:17 AM, Domeij, Anders <anders.domeij@xxxxxxxxxx> wrote:

Hello Markus,

 

Finally,

I have just opened 2 bugs in Bugzilla https://bugs.eclipse.org/bugs/show_bug.cgi?id=295042 and https://bugs.eclipse.org/bugs/show_bug.cgi?id=295045.

I’ve attached the source files with the bug fixes to the first one.

 

I’ve also left a message in the dev mailing list.

 

If you have any comments or questions feel free tol mail me.

 

Rgds

/Anders

 

---

From: Markus Sabadello [mailto:markus.sabadello@xxxxxxxxx]
Sent: den 21 oktober 2009 14:47

To: Domeij, Anders
Subject: Re: Higgins SAML2 IdP

 

Not right now.. I'll try to take a look later this week..

Markus

On Wed, Oct 21, 2009 at 2:32 PM, Domeij, Anders <anders.domeij@xxxxxxxxxx> wrote:

Do you have time to test it before I ‘go formal’

 

---

From: Markus Sabadello [mailto:markus.sabadello@xxxxxxxxx]
Sent: den 21 oktober 2009 14:25

To: Domeij, Anders
Subject: Re: Higgins SAML2 IdP

 

Hello,

Cool, sounds great. Could you please do the following:

1. Go to https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Higgins&format=guided. Log in or create a Bugzilla account if you don't have one.
2. Create a new bug for Higgins. Select "Utilities" in the "Component" list.
3. Fill out some of the text fields that make sense, e.g. just copy&paste your e-mail.
4. After the bug is filed, attach the 2 files to the bug.
5. Then send a message to the Higgins dev list (not just me), if possible with the bug ID.

Sorry, but that's the formal process according to Eclipse rules..

I can then take a look and check in the changes :)

thanks
Markus

On Wed, Oct 21, 2009 at 1:03 PM, Domeij, Anders <anders.domeij@xxxxxxxxxx> wrote:

Hello Marcus,

 

I’m sending you the source trees (zipped) for org.eclipse.higgins.util.saml & org.eclipse.higgins.util.saml.test.

 

There have been many small changes in many files J

 

The XML generated for different SAML elements is now more strict so that the individual elements can be tested with JUnit.

As far as the JUnit tests being all-inclusive and relevant, I have’t had the time nor do I have enough experience of SAML usage to asses their value. At least now they run….

 

As for SAML ver 2

I have added the SAML2LogoutRequest/Response elements as described in the Web SSO Profile.

 

Hope you have time to diff and look at it.

Comments appreciated

 

When (if) you add the changes to SVN please let me know so I can check them out again. For the time being I’ll keep using my own copies in the project I’m currently working on.

 

Rgds

/Anders