Hi,
To my understanding, this is a
class intended to simplify working with Entities - providing some
out-of-the-box entity implementation to be extended
and only the the functionality that
needs to be modified to overloaded. However all its members are made private and
besides the constructors, there is
no way to modify them once they have
been set. This is fine for all complex member - context, model, the
attributes collection, etc since one can get
a non-const reference and modify content
but entityId and type are
immutable. Wouldn't it be better to make the members protected or introduce
protected setters
for those 2 elements may be at
BasicEntity level? Its not a problem one cannot work around it (overriding
getEntity() and getType() doing deep copy of BasicEntity(),
etc)
but I thought it'd be nice to give a bit
more control to derived classes.
George
**********************************************************************
This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.
**********************************************************************
|