| Re: [higgins-dev] Update on Higgins Patch 1.0.1 status - Friday 4-April |
Brian, We've found the reason of the latest regressions we have. Mike, Could look at your latest changes to org.eclipse.higgins.sts.binding.axis1x.client.SecurityTokenServiceClientBinding? As mater of fact you removed setting up of soap header and this change broke all previously working requests to remote IdPs (sts requests for managed cards). See attached "before (valid).xml" and "now (invalid).xml" for an example. I'd propose to revert some of your changes as it done in the attached patch.txt Would you disagree? -- Thanks, Valery Friday, April 4, 2008, 4:23:05 PM, you wrote: > hi All - quick update on Higgins 1.0.1 patch release. > We have run into some regression issues. We are in the process of > debugging and fixing these. Due to this issue - we propose to > postpone the 1.0.1 release to Wed 9-April-08. > Will provide more updates as conditions warrent. Please let me know > if you have any questions/concerns. > regards...Brian > Brian Walker > VP of Engineering > Parity Communications Inc > cell: 781-801-0254 > _______________________________________________ > higgins-dev mailing list > higgins-dev@xxxxxxxxxxx > https://dev.eclipse.org/mailman/listinfo/higgins-dev
Attachment:
before (valid).xml
Description: XML document
Attachment:
now (invalid).xml
Description: XML document
Index: ./org.eclipse.higgins.sts.binding.axis1x.client/src/org/eclipse/higgins/sts/binding/axis1x/client/SecurityTokenServiceClientBinding.java
===================================================================
--- ./org.eclipse.higgins.sts.binding.axis1x.client/src/org/eclipse/higgins/sts/binding/axis1x/client/SecurityTokenServiceClientBinding.java (revision 14385)
+++ ./org.eclipse.higgins.sts.binding.axis1x.client/src/org/eclipse/higgins/sts/binding/axis1x/client/SecurityTokenServiceClientBinding.java (working copy)
@@ -122,8 +122,7 @@
final java.util.List listSecurityElements = securityInformation.getSecurityElementList();
for (int i = 0; i < listSecurityElements.size(); ++i)
{
- final org.eclipse.higgins.sts.api.ISecurityElement securityElement = (org.eclipse.higgins.sts.api.ISecurityElement)listSecurityElements.get
- (i);
+ final org.eclipse.higgins.sts.api.ISecurityElement securityElement = (org.eclipse.higgins.sts.api.ISecurityElement)listSecurityElements.get(i);
if (null == securityElement)
{
String errMsg = MsgHelper.getString(MsgHelper.securitytoken_from_securityinformation_is_null);
@@ -135,6 +134,7 @@
final org.apache.axis.message.MessageElement meSecurityToken = new org.apache.axis.message.MessageElement(domSecurityToken);
sheSecurityHeader.addChild(meSecurityToken);
}
+ this.tokenServiceClient.setHeader(sheSecurityHeader);
}
if (null != request.getTransportUsername())
{