| Re: [higgins-dev] IdAS notes |
|
On #5, why do we need the cardinality methods on IAttributeModel? Is it so we can say whether the attribute is optional or required on a subject type?
If so, it might make more sense to have two lists of attribute models on an IDigitalSubjectModel. Like getRequiredAttributeModels() and getOptionalAttributeModels(). I say this because an IAttributeModel itself shouldn't dictate whether it's always required or always optional. THat should be specified on the IDigitalSubjectModel.
Jim
>>> "Sergey Lyakhov" <slyakhov@xxxxxxxxxxxxxx> 6/1/07 8:00 AM >>> Jim, There are some additional proposals: 6. IMetadata interface has two methods - getID() - returns HOWL type, and get Type() - returns xml type of data. We need the same methods for ISimpleValue, because it also has two such types. In addition, (it is not principal), I think it will be more correct to use the same name of methods which return the HOWL type of objects (subject, attribute, values etc.). So, I propose to use getType() name for methods which return HOWL type (of subject, attribute, value, metadata) and getXMLType() to return xml type of simple value and metadata. 7. There are some methods in IAttribute (addValue(URI), addSimpleValue(URI, Object) and addComplexValue(URI)), which require URI type of new value. This URI parameter is redundant, because Attribute can have only one type of value (type of values is equal to the type of attribute). 8. Perhaps it will be useful to add ISingleValuedAttribute getSingleValuedAttribute(URI attrID) method to IHasAttributes interface. 9. We need to add cancelUpdates() method to IContext interface. This method should be used by user to cancel all changes made after last invocation of applyUpdates(). I am sure it is very important method. Thanks, Sergey Lyakhov ----- Original Message ----- From: Sergey Lyakhov To: higgins-dev@xxxxxxxxxxx Sent: Thursday, May 24, 2007 8:49 PM Subject: Re: [higgins-dev] IdAS notes Jim, In addition: 5. We need to add two methods int getMinCardinality() and int getMaxCardinality() to IAttributeModel interface. Thanks, Sergey Lyakhov ----- Original Message ----- From: Sergey Lyakhov To: higgins-dev@xxxxxxxxxxx Sent: Tuesday, May 22, 2007 9:44 PM Subject: [higgins-dev] IdAS notes Jim, I have some notes about IdAS: 1. I suppose IMetadataModel interface should extend IModel interface (to inherit IDisplayData getDisplayData() method); 2. We need to add two methods getMetadataSet() and getMetadata(URI) to IDigitalSubjectModel, IAttributeModel and IAttributeValueModel; 3. IAttributeValueModel interface declares some methods (isValidValue(Object valueForm), isValid(String lexicalForm), toValueForm(String lexicalForm) and toLexicalForm(Object value)) which are not reqiured by IAttributeComplexValueModel. I proprose to move these methods from IAttributeValueModel to IAttributeSimpleValueModel; 4. There are some classes which contain wrong HOWL URIs (at least wrong base URI - AuthNNamePasswordMaterials, AuthNSelfIssuedMaterials etc.). Pershaps we need some class which will contain HOWL URIs constants. Thanks, Sergey Lyakhov _______________________________________________ higgins-dev mailing list higgins-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/higgins-dev _______________________________________________ higgins-dev mailing list higgins-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/higgins-dev _______________________________________________ higgins-dev mailing list higgins-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/higgins-dev |