Re: [gmf-dev] Bug #371888 - Refactoring to support ComboDirectEditManage

[Aurélien Pupier <aurelien.pupier@xxxxxxxxxxxxxx>]

Hi,

comments inlined

2012/3/2 Michael Golubev <golubev@xxxxxxxxxxxx>

Hello, 

The number of lines modified is above 250. But a lot of lines have just move. Do we need to count them?

Sorry, no idea, never heard about LOCs counting for patches at all. 

Can you share some links to LOC-related policies I missed?

http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf

 

Who is the contributor?
Michael you open the bug but it is Svyatoslav Kovalsky that provided the patchs. He is not a committer, isn't it?

Svyatoslav Kovalsky is the actual contributor. 

I hope he will be a committer soon, but for GMF-T and definitely not for GMF Runtime. 

If i understood well the link that I provide above. be a committer, even not on the same project, makes a difference.

 

I think that I need to open a CQ. Anthony can you confirm it? or do you think that I just need to put IP flag?

To my understanding IP Log flag for the patch should be enough. 

Regards, 

-- 

Michael "Borlander" Golubev
Eclipse Committer (GMF, UML2Tools)
at Montages Think Tank, Prague, Czech Republic

Montages AG
Stampfenbachstr. 48, CH-8006 Zürich

tel:    +41 44 260 75 57

mob: +420 602 483 463

_______________________________________________
gmf-dev mailing list
gmf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gmf-dev

regards,

--

Aurelien Pupier
R&D Engineer, BOS Studio Developer
QA Project Leader

email : aurelien.pupier@xxxxxxxxxxxxxx

This message and any attachment (the "message") is intended solely for the addressees and is confidential. If you receive this message by mistake, please delete it and notify the sender immediately. Any use not in accordance with its purpose, any out-spread or disclosure, either as a whole or partially, is prohibited except with formal approval. Internet cannot guarantee the integrity of this message, therefore BonitaSoft will not be liable for the message if modified.