[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[gmf-dev] IUndoableOperation changes in the platform cause AssertionFailedException and breaks GMF
|
Hi Team,
As a result of the fix in
https://bugs.eclipse.org/bugs/show_bug.cgi?id=218467 you can no longer
create a GMF command with a null label.
I raised https://bugs.eclipse.org/bugs/show_bug.cgi?id=224706 on the GMF
Runtime but this affects the GMF tooling's generated code as well.
It is a common use case to create GMF commands without a label.
CompositeCommand with a label and the composite command wrapping commands
without a label.
We also use commands that do not have to show up in the undo stack, so some
have null labels.
It would appear we have use cases where the label is created after the
command is created (i.e by looking up a translated string and calling
setLabel()).
I am trying to access how major a problem this is, but our GMF clients are
not going to any backward compatibility when they adopt M6 (i.e. M6 will
require everyone to regenerate their code).
I assume it is ok to replace null with "" but this means we are creating
additional strings.
Cheers...
Anthony
--
Anthony Hunter mailto:anthonyh@xxxxxxxxxx
Software Development Manager: Eclipse Open Source Components
IBM Rational Software: Aurora / GMF / Modeling Tools
Phone: 613-270-4613
