Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [gmf-dev] JUnit Test failures in org.eclipse.gmf.tests.runtime.diagram.ui 
Hi,

 Updating on Ubuntu 7.04 didn't help.
 Although I investigated problem a bit further. It seems that the root
of a problem is a DiagramEventBrokerTests.class, and in particular
testBlockingUI_Unprotected test, which fails and causes all subsequent
tests to fail too.

 I was unable to make "18 test failures" repeatable running test on a
builder machine manually from the Eclipse workspace, but I found another
problem which may be related to this one. When you run
DiagramEventBrokerTests tests on Ubuntu platform, and switch focus off
the opened Eclipse window, you get the following stacktrace:


Exception in thread "Thread-2" java.lang.UnsupportedOperationException
	at java.util.AbstractList.add(AbstractList.java:151)
	at java.util.AbstractList.add(AbstractList.java:89)
	at
java.util.AbstractCollection.addAll(AbstractCollection.java:318)
	at
org.eclipse.gmf.runtime.diagram.core.DiagramEditingDomainFactory$Diagram
EditingDomain.postcommit(DiagramEditingDomainFactory.java:199)
	at
org.eclipse.emf.transaction.impl.TransactionalEditingDomainImpl.deactiva
te(TransactionalEditingDomainImpl.java:475)
	at
org.eclipse.emf.transaction.impl.TransactionImpl.close(TransactionImpl.j
ava:531)
	at
org.eclipse.emf.transaction.impl.TransactionImpl.commit(TransactionImpl.
java:372)
	at
org.eclipse.gmf.runtime.diagram.core.DiagramEditingDomainFactory$Diagram
EditingDomain.postcommit(DiagramEditingDomainFactory.java:219)
	at
org.eclipse.emf.transaction.impl.TransactionalEditingDomainImpl.deactiva
te(TransactionalEditingDomainImpl.java:475)
	at
org.eclipse.emf.transaction.impl.TransactionImpl.close(TransactionImpl.j
ava:531)
	at
org.eclipse.emf.transaction.impl.TransactionImpl.rollback(TransactionImp
l.java:424)
	at
org.eclipse.emf.workspace.AbstractEMFOperation.rollback(AbstractEMFOpera
tion.java:455)
	at
org.eclipse.emf.workspace.AbstractEMFOperation.execute(AbstractEMFOperat
ion.java:163)
	at
org.eclipse.gmf.tests.runtime.diagram.ui.logic.DiagramEventBrokerTests$3
.run(DiagramEventBrokerTests.java:241)
	at java.lang.Thread.run(Thread.java:595)


 Again, this seems to be due to the fact that
TransactionImpl.getNotifications() returns Collections.EMPTY_LIST if
there're no events:

	public List getNotifications() {
		return (notifications == null)? Collections.EMPTY_LIST :
notifications;
	}

And DiagramEditingDomainFactory.postcommit() tries to modify it

	[199]
originatingTransaction.getNotifications().addAll(notifications);

Hope this can help to solve the mysterious "18 test failures" problem.

 As a temporarily solution, shall we comment out DiagramEventBrokerTests
from diagram.ui.AllTests for the RC2?

Best regards,
Max


-----Original Message-----
From: gmf-dev-bounces@xxxxxxxxxxx [mailto:gmf-dev-bounces@xxxxxxxxxxx]
On Behalf Of Max Feldman
Sent: Monday, May 28, 2007 9:41 PM
To: GMF Project developer discussions.
Subject: RE: [gmf-dev] JUnit Test
failuresinorg.eclipse.gmf.tests.runtime.diagram.ui for lastFriday's
Integrationdriver

Anthony,

 I'll reinstall builder with Ubuntu 7.04. Will see if it solves it.

Bests,
Max

-----Original Message-----
From: gmf-dev-bounces@xxxxxxxxxxx [mailto:gmf-dev-bounces@xxxxxxxxxxx]
On Behalf Of Anthony Hunter
Sent: Monday, May 28, 2007 9:03 PM
To: GMF Project developer discussions.
Subject: RE: [gmf-dev] JUnit Test failures
inorg.eclipse.gmf.tests.runtime.diagram.ui for last Friday's
Integrationdriver

Hi Again,

I only get one failure on Ubuntu 6.10.
One failure using both the IBM and SUN 1.5 JRE.
I get the same failure on RedHat.

I have to run the tests from AllTests.java. I cannot get the tests to
run
from test.xml like the build does.

Cheers...
Anthony
--
Anthony Hunter mailto:anthonyh@xxxxxxxxxx
Software Development Manager: Eclipse Open Source Components
IBM Rational Software: Aurora / Modeling Tools
Phone: 613-591-7037



 

  From:   Anthony Hunter/Ottawa/IBM@IBMCA

 

  To:     "GMF Project developer discussions." <gmf-dev@xxxxxxxxxxx>

 

  Cc:     "GMF Project developer discussions." <gmf-dev@xxxxxxxxxxx>,

          gmf-dev-bounces@xxxxxxxxxxx

 

  Date:   28/05/2007 12:19 PM

 

  Subject RE: [gmf-dev] JUnit Test failures in

  :       org.eclipse.gmf.tests.runtime.diagram.ui for last Friday's

          Integration   driver

 





Hi Max,

Ubuntu is not currently on the Eclipse supported platforms list so the
GMF
Runtime developers do not have access to this platform.

I do have access to a Ubuntu 7.04 workstation that I upgraded from 6.10
that I used to test https://bugs.eclipse.org/bugs/show_bug.cgi?id=164623
.
I did have GEF JUnit failures on Ubuntu 6.10.

I will try running org.eclipse.gmf.tests.runtime.diagram.ui on Ubuntu
7.04
this afternoon.

I would suggest that since it is easy, we make the jump to Ubuntu 7.04
for
RC2.

Still sounds like we can push RC1 for now.

Cheers...
Anthony
--
Anthony Hunter mailto:anthonyh@xxxxxxxxxx
Software Development Manager: Eclipse Open Source Components
IBM Rational Software: Aurora / Modeling Tools
Phone: 613-591-7037




  From:   "Max Feldman" <Max.Feldman@xxxxxxxxxxx>

  To:     "GMF Project developer discussions." <gmf-dev@xxxxxxxxxxx>

  Date:   28/05/2007 10:07 AM

  Subject RE: [gmf-dev] JUnit Test failures in
  :       org.eclipse.gmf.tests.runtime.diagram.ui for last Friday's
          Integration driver





Hi Anthony,

 We use Ubuntu 6.10 (Edgy Eft) x86 with the Jre 1.5.0_11. Although
Ubuntu 7.04 does seem to solve our problems with tests, so if these are
really difficult to fix, let me know I'll try to switch the builder to
7.04.

Regards,
Max


-----Original Message-----
From: gmf-dev-bounces@xxxxxxxxxxx [mailto:gmf-dev-bounces@xxxxxxxxxxx]
On Behalf Of Anthony Hunter
Sent: Monday, May 28, 2007 2:59 PM
To: GMF Project developer discussions.
Subject: [gmf-dev] JUnit Test failures in
org.eclipse.gmf.tests.runtime.diagram.ui for last Friday's Integration
driver


Hi Team,

The 18 JUnit Test failures in org.eclipse.gmf.tests.runtime.diagram.ui
are
back in last Friday's Integration driver.
http://download.eclipse.org/modeling/gmf/downloads/drops/I-I20070525-200
705251500/testResults.php

Can you tell us what Linux platform the build machine is?

As well, what JRE are you using?

We may have to push RC1 again today with the errors while we figure this
one out.

Cheers...
Anthony
--
Anthony Hunter mailto:anthonyh@xxxxxxxxxx
Software Development Manager: Eclipse Open Source Components
IBM Rational Software: Aurora / Modeling Tools
Phone: 613-591-7037

_______________________________________________
gmf-dev mailing list
gmf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gmf-dev
_______________________________________________
gmf-dev mailing list
gmf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gmf-dev


_______________________________________________
gmf-dev mailing list
gmf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gmf-dev


_______________________________________________
gmf-dev mailing list
gmf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gmf-dev
_______________________________________________
gmf-dev mailing list
gmf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gmf-dev

Back to the top