Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [gemini-dev] Fwd: [gemini.blueprint] Fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=351755 (#1)

Thanks :-)

I guess we'll just have to make sure we don't accidentally do development of our projects on the github site, though...

On 19/11/2012 11:42 AM, Wayne Beaton wrote:
Done (I'm on a roll).

Wayne

On 11/19/2012 11:26 AM, michael keith wrote:
The one and only.

On 19/11/2012 11:24 AM, Wayne Beaton wrote:
I agree.

Glyn should be able to add team members. I can as well if you tell me your GitHub id.

FWIW, I did try to add you specifically, but didn't have confidence that GitHub id "mkeith" was you.

Wayne

On 11/19/2012 11:15 AM, michael keith wrote:
Did you say *all* of the Gemini repos?
Then we should have the Gemini project leads be part of that team.

On 19/11/2012 10:53 AM, Wayne Beaton wrote:
I set up a "Gemini" team at GitHub with you as a member that includes all of the Gemini repositories. You should be able to add additional members. I recommend that you keep membership in the team restricted to committers, but it's really your call.

I'm pretty sure that this will result in pull request emails being sent to you and other members of the team.

I'll see if I can sort out how to make it send mail to the dev list.

Wayne

On 11/19/2012 05:12 AM, Glyn Normington wrote:
Thanks Wayne! This pull request just showed up in my inbox because Matt added a comment to bug 351755.

I wonder if there's some way to route github email through to the corresponding project developer mailing lists? Seems a shame if you have to act as link man forever more. ;-)

Regards,
Glyn

On 17 Nov 2012, at 01:48, Wayne Beaton wrote:

FYI,

Wayne

-------- Original Message --------
Subject: [gemini.blueprint] Fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=351755 (#1)
Date: Fri, 16 Nov 2012 16:10:38 -0800
From: Matt Bishop <notifications@xxxxxxxxxx>
Reply-To: eclipse/gemini.blueprint <reply+i-8436083-ab88c6a9fafba297d9411b58aa4ec2418d49f146-555569@xxxxxxxxxxxxxxxx>
To: eclipse/gemini.blueprint <gemini.blueprint@xxxxxxxxxxxxxxxxxx>


This commit brings blueprint into better compliance with the R4.2 blueprint spec, specifically section 121.13.5 Type Compatibility, which states that the blueprint service should export the package "org.osgi.service.blueprint". Gemini did not do so, which caused bundles built to expect this package's presense to fail to load (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=351755)

The fix itself simply puts a unused Marker class in the right package so that Bundlor will add the correct package to gemini-core's manifest.

You can merge this Pull Request by running:

  git pull https://github.com/mattbishop/gemini.blueprint master

Or view, comment on, or merge it at:

  https://github.com/eclipse/gemini.blueprint/pull/1

Commit Summary

File Changes

  • A core/src/main/java/org/osgi/service/blueprint/BlueprintMarker.java (14)
  • M core/template.mf (47)

Patch Links


Reply to this email directly or view it on GitHub.

_______________________________________________
gemini-dev mailing list
gemini-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gemini-dev

  
_______________________________________________
gemini-dev mailing list
gemini-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gemini-dev

--
Wayne Beaton
The Eclipse Foundation
Twitter: @waynebeaton
Explore Eclipse Projects
EclipseCon 2013


_______________________________________________
gemini-dev mailing list
gemini-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gemini-dev

--
Wayne Beaton
The Eclipse Foundation
Twitter: @waynebeaton
Explore Eclipse Projects
EclipseCon 2013

--
Wayne Beaton
The Eclipse Foundation
Twitter: @waynebeaton
Explore Eclipse Projects
EclipseCon 2013

Back to the top