gef3d-dev

[gef3d-dev] Project meta data is out of date for technology.gef3d

emo@xxxxxxx (portal on behalf of emo) — Fri, 05 Jun 2009 04:00:14 GMT

Jens,
Projects are required to keep meta data up to date using the MyFoundation
Portal (http://portal.eclipse.org/).  The following problems were found
with this project's meta-data:

* There is no next/future release of this project. All Eclipse projects
must have a "next release" planned and scheduled.

Re: [gef3d-dev] Render3DEditPart

kristian.duske@xxxxxxx (Kristian Duske) — Wed, 03 Jun 2009 00:44:55 GMT

God, I'm stupid. And tired. Sorry for this, I somehow didn't see that this was mailed to the list.

Re: [gef3d-dev] Render3DEditPart

kristian.duske@xxxxxxx (Kristian Duske) — Wed, 03 Jun 2009 00:44:12 GMT

Hi Miles,

I think you accidentally send this to me via email. I'll have a look at this tomorrow, now it's time to sleep!

Best regards
Kristian

[gef3d-dev] Render3DEditPart

milesparker@xxxxxxx (Miles Parker) — Wed, 03 Jun 2009 00:39:14 GMT

Hi all,

Here is just a convenience class that steals code from SolidCube to delegate a renderer back to the enclosing edit part. (There are some other classes that handle the location bits, etc..) I'm finding it useful for simplifying custom rendering within GEF as all you have to do is provide the factory for the edit part and then return an implementing (anonymous) class from EditPartFactory.

/**

* are made available under the terms of the Eclipse Public License v1.0

* which accompanies this distribution, and is available at

* http://www.eclipse.org/legal/epl-v10.html

package org.eclipse.amp.agf3d;

import org.eclipse.draw2d.IFigure;

import org.eclipse.draw3d.Figure3D;

import org.eclipse.draw3d.IFigure3D;

import org.eclipse.draw3d.RenderContext;

import org.eclipse.draw3d.geometry.Position3D;

import org.eclipse.draw3d.geometry.Vector3fImpl;

import org.eclipse.draw3d.graphics3d.Graphics3D;

import org.eclipse.draw3d.graphics3d.Graphics3DDraw;

import org.eclipse.draw3d.shapes.AbstractModelShape;

import org.eclipse.draw3d.util.ColorConverter;

import org.eclipse.gef.editparts.AbstractGraphicalEditPart;

import org.eclipse.swt.graphics.Color;

/**

* An edit part that allows drawing of arbitrary figures into the current rendering context.

* @author Miles Parker

* @author Kristian Duske

public class RenderEdit3DPart extends AbstractGraphicalEditPart {

public static final int SCALE = 20;

private static final float[] DEFAULT_COLOR = new float[] { 0, 0, 0, 1 };

private final float[] m_color = new float[] { DEFAULT_COLOR[0], DEFAULT_COLOR[1], DEFAULT_COLOR[2],

DEFAULT_COLOR[3] };

AbstractModelShape shape;

boolean update = true;

/**

* @return

* @see org.eclipse.gef.editparts.AbstractGraphicalEditPart#createFigure()

protected IFigure createFigure() {

final IFigure3D figure = new Figure3D() {

public void render(RenderContext renderContext) {

Position3D fp = getPosition3D();

shape.setPosition(fp);

shape.render(renderContext);

}

};

shape = new AbstractModelShape() {

protected void performRender(RenderContext renderContext) {

Graphics3D g3d = renderContext.getGraphics3D();

glSetColor(g3d);

renderShape(g3d);

}

@Override

protected void setup(RenderContext renderContext) {

Graphics3D g3d = renderContext.getGraphics3D();

g3d.glPolygonMode(Graphics3DDraw.GL_FRONT_AND_BACK, Graphics3DDraw.GL_FILL);

}

};

figure.getPosition3D().setSize3D(new Vector3fImpl(SCALE, SCALE, SCALE));

return figure;

}

/**

* Render shape.

* @param g3d the g3d

protected void renderShape(Graphics3D g3d) {

}

/**

* Sets the color of this cube.

* @param i_color the color

* @param i_alpha the alpha value

* @throws NullPointerException if the given color is null

public void setColor(Color i_color, int i_alpha) {

if (i_color == null) {

throw new NullPointerException("i_color must not be null");

}

ColorConverter.toFloatArray(i_color, i_alpha, m_color);

}

/**

* Sets the color of the given face.

* @param i_color the color as an int value (fomat 0x00BBGGRR)

* @param i_alpha the alpha value

public void setColor(int i_color, int i_alpha) {

ColorConverter.toFloatArray(i_color, i_alpha, m_color);

}

/**

* Gl set color.

* @param g3d the g3d

private void glSetColor(Graphics3D g3d) {

float r = m_color[0];

float g = m_color[1];

float b = m_color[2];

float a = m_color[3];

g3d.glColor4f(r, g, b, a);

}

/**

* @see org.eclipse.gef.editparts.AbstractEditPart#createEditPolicies()

protected void createEditPolicies() {

}

[gef3d-dev] Added feedback figures for connections

developer@xxxxxxx (Jens v. P.) — Mon, 01 Jun 2009 15:53:36 GMT

Dear GEF3D developers,

I have started fixing bug

https://bugs.eclipse.org/bugs/show_bug.cgi?id=269337 -- Connections can not be selected

I haven't fixed it completely, as connections cannot be selected yet, but at least when drawing a connection, a dummy line is drawn. This is also not working 100% correctly, I assume this has something to do with wrongly converted coordinates. As this is a general problem, I have added a new bug report summarizing this problem:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=278634 -- Coordinate conversion not (always) working properly

Since drawing feedback connections probably is an interesting feature, here is a short note on how to activate it:

A new policy must be installed on NodeEditParts. This is a snippet from an example editor, I will update the graph example as soon as possible:

borgFactory.addAssimilator(new AbstractPolicyModifier() {

    public boolean match(EditPart part) {
        return part instanceof NodeEditPart;
    }

    public void modifyPolicies(EditPart io_editpart) {
        io_editpart.installEditPolicy(
            ShowSourceFeedback3DEditPolicy.ROLE,
            new ShowSourceFeedback3DEditPolicy());
    }
});

Pretty simple, I guess ;-)

I have also added a new class org.eclipse.draw3d.geometryext.PointList3D which is a 3D version of PointList (and a List)! In order to keep in sync with GEF's design, Polyline3D's getter and setter (of its point list) is working with references (just as the original 2D version). This is a little bit tricky, since in most cases the following workflow is executed: get point list, modify point list, set point list. The last setter is only called in order to update the figure!

The PointList3D is internally working with Vector3fImpl, but it can be used in 2D contexts as well because PointList is its super class. 2D and 3D values are kept in sync (actually, there are only 3D values ;-).

Cheers,

Jens

Re: [gef3d-dev] Copyright issues related to CQ2806

developer@xxxxxxx (Jens v. P.) — Wed, 29 Apr 2009 07:36:39 GMT

Hi all,

On 28.04.2009, at 18:20, Kristian Duske wrote:

Draw3D:
Haven't found anything that differs from your results in Draw3D.

OK

GEF3D:
HandleBounds3D doesn't look like it was copied from anywhere, it simply extends two interfaces and adds one method. What's up with that?


The comment has been copied.

org.eclipse.gef3d.handles.MoveHandle3D
org.eclipse.gef3d.handles.MoveHandle3DFactory
Same goes for this class. Even if it was copied at one point, the code in there is so simple that I don't think that anyone can have a copyright on it.

Again, comments were copied and the basic structure (what to return when).

org.eclipse.gef3d.handles.MoveHandleLocator3D
org.eclipse.gef3d.handles.NonResizableHandle3DFactory
org.eclipse.gef3d.handles.ResizableHandle3DFactory
org.eclipse.gef3d.handles.ResizeHandle3D
It seems that the classes in this entire package are so simple - I don't see how that stuff can be copyrighted. On the other hand, better safe than sorry I guess.

Exactly: "Better safe than sorry". I assume in most cases it would be difficult to copyright any stuff, but it's all EPL, we (I) definitely copied things, so I have no problem adding this copyright notice.

I have modified the headers of the following files: org.eclipse.gef3d.preferences.BitFieldEditor (was copied from org.eclipse.jface.preference.RadioGroupFieldEditor)

This may be a problematic case since we don't use the jface plugin from which RadioGroupFieldEditor originates - Sharon Corbett noted that if we didn't reuse the plugin we copied from, we need to open a new CQ.


OK, we'll add this file to the list and ask Sharon.

org .eclipse .gef3d.ui.parts.GraphicalEditor3D#createGraphicalViewer(Composite) - copied from GEF GraphicalViewer class. org .eclipse .gef3d .examples .ecore.diagram.part.EcoreDiagramEditor3D#configureGraphicalViewer() was copied from GEF GraphicalEditor and GMF DiagramEditor.


Oh yes, of course. So, we'll submit the following list to the CQ:

Draw3D:
org.eclipse.draw3d.AbstractRouter3D
org.eclipse.draw3d.ChopboxAnchor3D
org.eclipse.draw3d.Connection3D
org.eclipse.draw3d.ConnectionAnchor3D
org.eclipse.draw3d.ConnectionRouter3D
org.eclipse.draw3d.FreeformLayer3D
org.eclipse.draw3d.Polyline3D
org.eclipse.draw3d.PolylineConnection3D
org.eclipse.draw3d.RelativeLocator3D
org.eclipse.draw3d.draw2dports.FreeformHelper

GEF3D:
org.eclipse.gef3d.editpolicies.NonResizableEditPolicy3D
org.eclipse.gef3d.editpolicies.ResizableEditPolicy3D
org.eclipse.gef3d.handles.AbstractHandle3D
org.eclipse.gef3d.handles.HandleBounds3D
org.eclipse.gef3d.handles.MoveHandle3D
org.eclipse.gef3d.handles.MoveHandle3DFactory
org.eclipse.gef3d.handles.MoveHandleLocator3D
org.eclipse.gef3d.handles.NonResizableHandle3DFactory
org.eclipse.gef3d.handles.ResizableHandle3DFactory
org.eclipse.gef3d.handles.ResizeHandle3D
org.eclipse.gef3d.tools.DragEditPartsTracker3D
org.eclipse.gef3d.tools.ResizeTracker3D
org.eclipse.gef3d.ui.parts.GraphicalEditor3DWithFlyoutPalette
org.eclipse.gef3d.ui.parts.GraphicalEditor3DWithPalette
org.eclipse.gef3d.preferences.BitFieldEditor

GEF3D-Examples:
org.eclipse.gef3d.ui.parts.GraphicalEditor3D
org.eclipse.gef3d.examples.ecore.diagram.part.EcoreDiagramEditor3D
org.eclipse.gef3d.examples.uml2.activity.part.UMLDiagramEditor3D
org.eclipse.gef3d.examples.uml2.clazz.part.UMLDiagramEditor3D
org.eclipse.gef3d.examples.uml2.usecase.part.UMLDiagramEditor3D

Cheers,

Jens

Re: [gef3d-dev] Copyright issues related to CQ2806

kristian.duske@xxxxxxx (Kristian Duske) — Tue, 28 Apr 2009 16:20:17 GMT

Hi everyone,

I have looked through the projects as well and found some minor things only.

Draw3D:


Haven't found anything that differs from your results in Draw3D.

GEF3D:
org.eclipse.gef3d.editpolicies.NonResizableEditPolicy3D
org.eclipse.gef3d.editpolicies.ResizableEditPolicy3D
org.eclipse.gef3d.handles.AbstractHandle3D
org.eclipse.gef3d.handles.HandleBounds3D

HandleBounds3D doesn't look like it was copied from anywhere, it simply extends two interfaces and adds one method. What's up with that?

org.eclipse.gef3d.handles.MoveHandle3D
org.eclipse.gef3d.handles.MoveHandle3DFactory

Same goes for this class. Even if it was copied at one point, the code in there is so simple that I don't think that anyone can have a copyright on it.

org.eclipse.gef3d.handles.MoveHandleLocator3D
org.eclipse.gef3d.handles.NonResizableHandle3DFactory
org.eclipse.gef3d.handles.ResizableHandle3DFactory
org.eclipse.gef3d.handles.ResizeHandle3D

It seems that the classes in this entire package are so simple - I don't see how that stuff can be copyrighted. On the other hand, better safe than sorry I guess.

org.eclipse.gef3d.tools.DragEditPartsTracker3D
org.eclipse.gef3d.tools.ResizeTracker3D
org.eclipse.gef3d.ui.parts.GraphicalEditor3DWithFlyoutPalette
org.eclipse.gef3d.ui.parts.GraphicalEditor3DWithPalette

I have modified the headers of the following files: org.eclipse.gef3d.preferences.BitFieldEditor (was copied from org.eclipse.jface.preference.RadioGroupFieldEditor)

This may be a problematic case since we don't use the jface plugin from which RadioGroupFieldEditor originates - Sharon Corbett noted that if we didn't reuse the plugin we copied from, we need to open a new CQ.

org .eclipse .gef3d.ui.parts.GraphicalEditor3D#createGraphicalViewer(Composite) - copied from GEF GraphicalViewer class. org .eclipse .gef3d .examples .ecore.diagram.part.EcoreDiagramEditor3D#configureGraphicalViewer() was copied from GEF GraphicalEditor and GMF DiagramEditor.

org .eclipse.gef3d.gmf.runtime.diagram.ui.editparts.DiagramRootEditPart3D - this one is fine, I didn't copy anything for it.

That's all I could find.

Best regards
Kristian

[gef3d-dev] Copyright issues related to CQ2806

developer@xxxxxxx (Jens v. P.) — Sun, 26 Apr 2009 16:16:21 GMT

Hi  all,

Sharon Corbett found some copyright issues in the GEF3D and Draw3D sources. We copied code from the original 2D projects (GEF, Draw2D), even marked the code as copied, but we didn't considered that in the copyright notices. I have compiled a list of files I have changed the copyright notices accordingly:

Draw3D:
org.eclipse.draw3d.AbstractRouter3D
org.eclipse.draw3d.ChopboxAnchor3D
org.eclipse.draw3d.Connection3D
org.eclipse.draw3d.ConnectionAnchor3D
org.eclipse.draw3d.ConnectionRouter3D
org.eclipse.draw3d.FreeformLayer3D
org.eclipse.draw3d.Polyline3D
org.eclipse.draw3d.PolylineConnection3D
org.eclipse.draw3d.RelativeLocator3D
org.eclipse.draw3d.draw2dports.FreeformHelper

GEF3D:
org.eclipse.gef3d.editpolicies.NonResizableEditPolicy3D
org.eclipse.gef3d.editpolicies.ResizableEditPolicy3D
org.eclipse.gef3d.handles.AbstractHandle3D
org.eclipse.gef3d.handles.HandleBounds3D
org.eclipse.gef3d.handles.MoveHandle3D
org.eclipse.gef3d.handles.MoveHandle3DFactory
org.eclipse.gef3d.handles.MoveHandleLocator3D
org.eclipse.gef3d.handles.NonResizableHandle3DFactory
org.eclipse.gef3d.handles.ResizableHandle3DFactory
org.eclipse.gef3d.handles.ResizeHandle3D
org.eclipse.gef3d.tools.DragEditPartsTracker3D
org.eclipse.gef3d.tools.ResizeTracker3D
org.eclipse.gef3d.ui.parts.GraphicalEditor3DWithFlyoutPalette
org.eclipse.gef3d.ui.parts.GraphicalEditor3DWithPalette

Could you have a look at the projects, too? Maybe I have overseen somethings. I wasn't sure about

org.eclipse.gef3d.gmf.runtime.diagram.ui.editparts.DiagramRootEditPart3D

Can you please check and answer to this mail? The issue is time criticial, since the CQ is "awating committer" (we have to upload files with changed copyright notices to the CQ).

Cheers,

Jens

Re: [gef3d-dev] FeedbackLayer3D -- weird code

developer@xxxxxxx (Jens v. P.) — Fri, 17 Apr 2009 08:17:12 GMT

Kristian,

On 17.04.2009, at 08:27, Kristian Duske wrote:

I took this code from de.feu.gef3d.topcased.modeler.uml.editor.UMLEditor3D $FeedbackLayer3D, so this is one of the classic "Who the hell wrote this?! - oh it was me" moments ;-). Frankly, I have no idea why it would do this. Doesn't seem to make sense.

Uups.. hehe.. ok. So, I have uncommented the weird part, the class is more or less empty right now, but maybe this will change in future versions.

Cheers

Jens

Re: [gef3d-dev] FeedbackLayer3D -- weird code

kristian.duske@xxxxxxx (Kristian Duske) — Fri, 17 Apr 2009 06:27:09 GMT

Hi Jens,

while fixing some problems with the GMF Multi-Editor 3D I found some strange things in org.eclipse.draw3d.FeedbackLayer3D. I have commented out the whole add(..) method, as it seems to only call its super method (or produce a stack overflow error, see comment). Is there something I missed?

I took this code from de.feu.gef3d.topcased.modeler.uml.editor.UMLEditor3D$FeedbackLayer3D, so this is one of the classic "Who the hell wrote this?! - oh it was me" moments ;-). Frankly, I have no idea why it would do this. Doesn't seem to make sense.

Regards
Kristian