[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [gef-dev] Getting to know the gef framework

Hi Alexander.
The problem occurs because the marquee checks all the edit parts in the editor for selectability before they are filtered by the marquee rectangle.
I created a patch and added it to the but, with a longer explanation and also some tests I did to check how the fix did.

Arieh


2012/3/25 Alexander Nyßen <alexander.nyssen@xxxxxxxxx>
Hi Arieh,

thanks for investigating. Yes, I agree. Do you think you could dig deeper and find out the cause for 186470?

Cheers
Alexander



Von meinem iPhone gesendet

Am 24.03.2012 um 19:00 schrieb vainolo <vainolo@xxxxxxxxx>:

Hi Alexander.
I reviewed all of the critical and major bugs of the GEF component which had status NEW. Since I am not sure what to do I didn't change anything in the bug themselves, but here are the results:
Critical:
1) Bug 332808 - [DnD] Drag & drop in Outline view crashes Eclipse: probably an SWT issue in MacOS. The creator said that he doesn't have time to work on the issue.
Major:
1) Bug 111257 - [DnD] Prevent illegal transfers between GEF-based editors: This is a real issue, but I would not catalog it as major since doing copy/paste or drag&drop between two different type of editors that have a different model is not something that happens every day.
2) Bug 141798 - TVT3.2:TCT482: FI: Edit menu Delete option grayed out: Still valid. The comments in the bug are OK.
3) Bug 186470 - [Tool] Targeting Tool selects parts at random during drag selection: Still valid. This can be a big problem for diagrams with a large number of editparts.
4) Bug 197628 - [Palette] Incorrect label in palette when BIDI language is used on Linux: Still relevant. I used Hebrew to reproduce the bug. This is not only a GEF problem because the same behavior is implemented in other parts of eclipse (i.e. the task editor behaves the same way).
5) Bug 226895 - Thai3.4: Thai line break does not work correctly on GEF's label: Could not reproduce, but I don't thing this is a major bug.
6) Bug 226897 - [Palette] Thai3.4: No word wrap in Palette's tooltip text: same as above.
7) Bug 300025 - [GraphLayout] CompoundDirectedGraph does not layout properly: I managed to reproduce the bug by playing a lot with the flow example editor, but could not arrive to a specific set of steps to reproduce it, so could not decide if it is a GEF problem or a problem in the flow example. 
8) Bug 341445 - [Ruler] Ruler not redrawn when resizing graphical viewer: no Mac available.
9) Bug 359195 - Toolbar Icons missing: unable to reproduce.

In my opinion, only bug 186470 is relevant for the next version of GEF. How would you like to go on from here? There are hundreds of lower priority bugs...

Arieh 

On Sun, Feb 19, 2012 at 5:35 PM, Alexander Nyssen <alexander.nyssen@xxxxxxxxx> wrote:
Hallo Arieh,

well, I think we should leave out enhancements at first and concentrate on the bugs.

Cheers
Alexander

Am 19.02.2012 um 14:40 schrieb vainolo:

Hi Alexander. I will start right away. What should I do with
enhancements (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=74784
for example)

Arieh

On Sun, Feb 19, 2012 at 1:58 PM, Alexander Nyssen
<alexander.nyssen@xxxxxxxxx> wrote:
Hi Arieh,

well, that's exactly what I meant with supporting us in triaging of bugs.
The main goal is to verify whether a reported bug (still) holds, whether the
information given in its description is meaningful enough to reproduce it,
etc. If you face such a bug and document your estimation (by adding a
comment), that would pretty much help us to get rid of the old bugs that no
longer hold, so we can then concentrate on the real issues...

Cheers
Alexander

Am 18.02.2012 um 22:58 schrieb vainolo:

Hi Alexander. I already went through some of the bugs in Bugzila but
couldn't find something to work out. Many bugs seem old and missing
information on how to reproduce. Can you point me to specific ones? I
also don't know what "triaging" means. Could you explain please?
Thanks

Arieh

On Thu, Feb 16, 2012 at 11:39 PM, Alexander Nyssen
<alexander.nyssen@xxxxxxxxx> wrote:

Hallo Arieh,


thanks for your offer. Well, in principal, Bugzilla would be a good starting

point. There are quite a few open bugs that could well be supported by

patches. Even without working on patches directly could even support us by

"triaging" some of the bugs that are listed as open but have not been

commented recently (I did some triaging already, but I did not manage to

look into all of them yet). Going through some of the bugs and verifying and

commenting on whether they still hold would help a lot.


If you want to support us with working on patches, please consider the

following two points:


a) GEF 3.x is strictly bound to retain API compatibility, so any bugs that

are fixed have be fixed without breaking the current API (i.e. you will have

to work with API tooling to ensure your fixes do not break the current API).

As this reduces some flexibility, we have initiated a GEF4 provisional

component (see http://wiki.eclipse.org/GEF/GEF4) recently, which is located

in its own git repository, where API may be evolved more flexibly. Up to now

however, we have only started to work on the development of a new Geometry

API there; after the Juno release it is planned to migrate the remaining 3.8

code base into the GEF4 repository as well as a starting point for evolving

the new API in parallel to the 3.x one. As such, if you take a look at  bugs

now, you may - concerning GEF 3.x - only investigate those that can be

solved without breaking the current API. After Juno, you could support the

work on the GEF4 provisional component as well, where these restrictions do

not hold.


b) we are currently modernizing the GEF 3.x infrastructure. That is, the GEF

build system has already been moved to Tycho, the GEF cvs repository has

been migrated to Git TODAY. However, the old cvs repository has not been

archived yet, and the contribution guide and all documentation about how to

contribute to GEF will have to be updated. I will post a message here as

soon as this is done (you may also CC to

https://bugs.eclipse.org/bugs/show_bug.cgi?id=351232, where the progress is

tracked). But if you want to start in advance, make sure to go against the

Git repository (http://git.eclipse.org/c/gef/org.eclipse.gef.git/).


Cheers

Alexander


Am 16.02.2012 um 15:46 schrieb vainolo:


Hi to all the GEF developers. I am using GEF to create a graphical editor

for a graphical language I'm developing for my PhD and I wanted to get to

know more of the insides of GEF.

I have already learned the basics (and written a tutorial which you can find

at http://vainolo.com/tutorials).

I can provide some of my spare time to develop features/solve bugs. Can

someone give me a pointer where to start?

Thanks


Arieh

_______________________________________________

gef-dev mailing list

gef-dev@xxxxxxxxxxx

https://dev.eclipse.org/mailman/listinfo/gef-dev



--

Dr. Alexander Nyßen

Dipl.-Inform.

Software-Engineer


Telefon: +49 (0) 231 / 98 60-210

Telefax: +49 (0) 231 / 98 60-211

Mobil: +49 (0) 151 /  17396743


http://www.itemis.de

alexander.nyssen@xxxxxxxxx


itemis AG

Am Brambusch 15-24

44536 Lünen


Rechtlicher Hinweis:


Amtsgericht Dortmund, HRB 20621


Vorstand: Jens Wagener (Vors.), Wolfgang Neuhaus, Dr. Georg Pietrek, Jens

Trompeter, Sebastian Neus


Aufsichtsrat: Dr. Burkhard Igel (Vors.), Stephan Grollmann, Michael Neuhaus




_______________________________________________

gef-dev mailing list

gef-dev@xxxxxxxxxxx

https://dev.eclipse.org/mailman/listinfo/gef-dev


_______________________________________________
gef-dev mailing list
gef-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gef-dev


--
Dr. Alexander Nyßen
Dipl.-Inform.
Software-Engineer

Telefon: +49 (0) 231 / 98 60-210
Telefax: +49 (0) 231 / 98 60-211
Mobil: +49 (0) 151 /  17396743

http://www.itemis.de
alexander.nyssen@xxxxxxxxx

itemis AG
Am Brambusch 15-24
44536 Lünen

Rechtlicher Hinweis:

Amtsgericht Dortmund, HRB 20621

Vorstand: Jens Wagener (Vors.), Wolfgang Neuhaus, Dr. Georg Pietrek, Jens
Trompeter, Sebastian Neus

Aufsichtsrat: Dr. Burkhard Igel (Vors.), Stephan Grollmann, Michael Neuhaus



_______________________________________________
gef-dev mailing list
gef-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gef-dev

_______________________________________________
gef-dev mailing list
gef-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gef-dev

--
Dr. Alexander Nyßen
Dipl.-Inform.
Software-Engineer

Telefon: +49 (0) 231 / 98 60-210
Telefax: +49 (0) 231 / 98 60-211
Mobil: +49 (0) 151 /  17396743

http://www.itemis.de 
alexander.nyssen@xxxxxxxxx 

itemis AG
Am Brambusch 15-24
44536 Lünen

Rechtlicher Hinweis:

Amtsgericht Dortmund, HRB 20621

Vorstand: Jens Wagener (Vors.), Wolfgang Neuhaus, Dr. Georg Pietrek, Jens Trompeter, Sebastian Neus

Aufsichtsrat: Dr. Burkhard Igel (Vors.), Stephan Grollmann, Michael Neuhaus



_______________________________________________
gef-dev mailing list
gef-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gef-dev


_______________________________________________
gef-dev mailing list
gef-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gef-dev

_______________________________________________
gef-dev mailing list
gef-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gef-dev