[gef-dev] Re: Fwd: [Bug 195527] Connections outside containers

[Anthony Hunter <anthonyh@xxxxxxxxxx>]

Hi Alexander

That is great that you can update the patch.

With regards to formatting, yes, the GEF project needs to do this. I have never liked the fact that GEF was not following the standard Eclipse formatting.

The blocker has always been the patches, if we reformat the code, all the contributed patches will be broken.

As a coincidence, I went through the patches again a while back and pinged the Bugzilla owners with questions. These patches are assigned to M6. All the other patches I would class as "not Helios".

After all the these patches are finalized, we would be in a good position to reformat all the GEF code using the standard Eclipse formatting.

Cheers...
Anthony
--
Anthony Hunter mailto:anthonyh@xxxxxxxxxx
Software Development Manager
IBM Rational Software: Aurora / Modeling Tools
Phone: 613-270-4613


Alexander Nyssen ---2010/02/18 05:29:45 PM---Hi Anthony, I will take care of this on Saturday, as tomorrow I will probably be quite busy. BTW, what do you think about defin

From:	Alexander Nyssen <any@xxxxxxxxxxxxxxxxxx>
To:	Anthony Hunter/Ottawa/IBM@IBMCA
Date:	2010/02/18 05:29 PM
Subject:	Fwd: [Bug 195527] Connections outside containers

---

Hi Anthony,

I will take care of this on Saturday, as tomorrow I will probably be quite busy. BTW, what do you think about defining an auto-format save action for the GEF projects? I noticed that the EMF Compare team has done so with their projects and I think this is a pretty good idea. I produced a couple of patches for them the last two weeks and I never ran into any layout related problems.

Best Regards
Alexander

Anfang der weitergeleiteten E-Mail:

Von: bugzilla-daemon@xxxxxxxxxxx
Datum: 18. Februar 2010 04:38:54 MEZ
An: any@xxxxxxxxxxxxxxxxxxxxxxxxx
Betreff: [Bug 195527] Connections outside containers

https://bugs.eclipse.org/bugs/show_bug.cgi?id=195527
Product/Component: GEF / draw2d

--- Comment #41 from Anthony Hunter <anthonyh@xxxxxxxxxx> 2010-02-17 22:38:43 EST ---
(From update of attachment 158397)
Hi Alexander.

Can you reattach the patch without changing the formatting of the existing,
unchanged code?

For example, someone looking at the patch sees
-void add(IFigure figure);
and thinks you removed or changed this method, when you just reformatted the
existing code.

This will also make the patch smaller.

--
Configure bugmail: https://bugs.eclipse.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.