Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
AW: [gef-dev] Auto-expose and marquee tools

The event thing is interesting. You get a mouse exit event if the pointer is outside the canvas? Mhm. I just implemented auto-scrolling into the marquee tool and it works as expected. 
 
Start marquee selection somewhere inside the viewer, move pointer below the viewer and the viewer scrolls down... The only thing I changed is to updateAutoexposeHelper in handleDragInProgress instead of handleHover.
 
BTW, I was refering to another "platform". Have you checked "My Computer" in Windows XP? You can start marquee selection anywhere and move the pointer outside the window -> it continues scrolling. That's what I implemented :)
 
I know that you are very busy, that's why I'm asking what you prefer. I'm going to prepare a patch and will open a PR and attache it.
 
I think the best would be to have something link an AutoexposeTool. I'll make the marquee tools configurable with the default beeing disabled. BTW, I already attached a patch to bug 44288 which makes the ViewportAutoexposeHelper configurable for allowing auto-scrolling if the pointer is moved outside the viewport.
 
Cu, Gunnar
 
 

________________________________

Von: gef-dev-admin@xxxxxxxxxxx im Auftrag von Randy Hudson
Gesendet: Mi 08.12.2004 16:34
An: gef-dev@xxxxxxxxxxx
Betreff: RE: [gef-dev] Auto-expose and marquee tools



When the mouse goes outside of the viewer on Motif or GTK (or maybe both), you get a mouse exit event and nothing more.  That is one reason why we don't autoscroll outside of the viewer: It wouldn't be consistent across platforms.  Another reason, is that it wouldn't be consistent with drag and drop operations, which must be inside the canvas.  The third reason is that "the platform" (pronounced Windows Explorer) only autoscrolls when inside the canvas (probably they are using native DND). 

I'd like to check out the marquee tool sometime but we are very busy with text editing for now. 

-randy 




"Gunnar Wagenknecht" <G.Wagenknecht@xxxxxxxxxxxx> 
Sent by: gef-dev-admin@xxxxxxxxxxx 

12/08/2004 12:22 AM 
Please respond to
gef-dev


To
<gef-dev@xxxxxxxxxxx> 
cc
Subject
RE: [gef-dev] Auto-expose and marquee tools	

		




We need it in the viewer. Currently we are using our own marquee tool which is mostly a lot of copy and paste because some important methods are "private" :( That's also because we changed it a little bit to use another figure when calculating if an editpart should be included or not. Basically it works like the marquee selection rectangle in Photoshop. I can start at the top left and select everything in my editor even if something is not visible because it scrolls. 
  
We don't use nested containers and our root editpart is creating the marquee tool. It is also returning a special expose helper that continues scrolling if the pointer is moved outside the viewer. PLUS, I have modified the tools to perform auto-exposing in handleDragInProgress instead of handleHover. We just feel that this is more common in other applications (start exposing as soon as the pointer is outside the viewer). 
  
  


________________________________

From: gef-dev-admin@xxxxxxxxxxx [mailto:gef-dev-admin@xxxxxxxxxxx] On Behalf Of Randy Hudson
Sent: Tuesday, December 07, 2004 4:59 PM
To: gef-dev@xxxxxxxxxxx
Subject: Re: [gef-dev] Auto-expose and marquee tools


Doesn't the auto-expose stuff expose editparts?  For the marquee tool, you would just want to expose the point where the lasso is currently dragged, right?  If so, maybe there's not much intersection between the two. 

Do you need marquee expose to work in nested scrollable containers, or just the viewer itself? 

-Randy 




"Gunnar Wagenknecht" <G.Wagenknecht@xxxxxxxxxxxx> 
Sent by: gef-dev-admin@xxxxxxxxxxx 

12/07/2004 12:06 AM 

Please respond to
gef-dev



To
<gef-dev@xxxxxxxxxxx> 
cc
Subject
[gef-dev] Auto-expose and marquee tools	


		





Hi!

I'd like to add and contribute support for auto-expose on the marquee
tools. Currently I see three options.

1. Move auto-expose implementation from TargetingTool into AbstractTool.
2. Move auto-expose implementation from TargetingTool into a new
abstract class AutoexposeTool and inherit from this class.
3. Reimplement auto-expose in the marquee tools.

I don't want to go the 3rd way. What's the best way to go? The 2nd is
the more cleaner way. 

BTW, I also attached a new patch to
https://bugs.eclipse.org/bugs/show_bug.cgi?id=44288

This adds an additional contructor which allows clients to create a
ViewportAutoexposeHelper that continues scrolling if the pointer is
moved outside the viewport.

Cu, Gunnar
_______________________________________________
gef-dev mailing list
gef-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/gef-dev


<<winmail.dat>>


Back to the top