It looks like there is something wrong with the published files and/or the downloads page. The GEF-Update-3.9.0M7.zip file doesn’t seem to be there. Could you take a look?

 

Thanks,

 

- Konstantin

 

 

From: gef-dev-bounces@xxxxxxxxxxx [mailto:gef-dev-bounces@xxxxxxxxxxx] On Behalf Of Alexander Nyßen
Sent: Monday, May 06, 2013 10:55 AM
To: GEF development
Subject: [gef-dev] GEF 3.9.0 M7 promoted

 

Hi all,

 

I recently promoted gef-master #679 as GEF-3.9.0M7 to update site and downloads area and updated the simultaneous release build aggregator files accordingly.

 

Cheers

Alexander

 

PS: I also cleaned up the drop files area as announced some time ago...

 

--  

Dr. Alexander Nyßen

Dipl.-Inform.

Software-Engineer

 

Telefon: +49 (0) 231 / 98 60-210

Telefax: +49 (0) 231 / 98 60-211

Mobil: +49 (0) 151 /  17396743

 

http://www.itemis.de 

alexander.nyssen@xxxxxxxxx 

 

itemis AG
Am Brambusch 15-24
44536 Lünen

Rechtlicher Hinweis:

Amtsgericht Dortmund, HRB 20621

Vorstand: Jens Wagener (Vors.), Wolfgang Neuhaus, Dr. Georg Pietrek, Jens Trompeter, Sebastian Neus

Aufsichtsrat: Dr. Burkhard Igel (Vors.), Stephan Grollmann, Michael Neuhaus

 

_______________________________________________
gef-dev mailing list
gef-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gef-dev

No virus found in this message.
Checked by AVG - www.avg.com
Version: 2013.0.3272 / Virus Database: 3162/6302 - Release Date: 05/06/13

I was talking of what is performed when updating the int-fields within the precision classes, i.e. the code within PrecisionGeometry#doubleToInteger():

 /**
    * Converts a double value into an integer value, avoiding rounding effects.
    *
    * @param doubleValue
    *            the double value to convert
    * @return the integer value for the double.
    */
   protected static final int doubleToInteger(double doubleValue) {
       return (int) Math.floor(doubleValue + 0.000000001);
   }

My point was that changing that from Math.floor() to Math.round() would probably be reasonable...

Cheers

Alexander

Am 18.04.2013 um 16:32 schrieb Randy Hudson <hudsonr@xxxxxxxxxx>:

Floor is used only because otherwise casting 0.9 and -0.9 to an int would give you the same number.  For positive values, it isn't doing anything.

Are you filling or drawing the rectangle?

-Randy

From:	Alexander Nyßen <alexander.nyssen@xxxxxxxxx>
To:	GEF development <gef-dev@xxxxxxxxxxx>,
Date:	04/18/2013 05:28 AM
Subject:	Re: [gef-dev] Why is converting from double to int done using the        Math.floor?
Sent by:	gef-dev-bounces@xxxxxxxxxxx

---

Hi Jan,

you are right, what you are facing here is one of the several inconsistencies within the current Draw2d geometry API, and one of the reasons we started to build a new one in GEF4. You would actually have to switch to integer-based precision when performing the calculation of the drawing position (i.e. y = line.y() - rect.height()) for the rectangle. I agree that in general rounding would probably lead to better results, so that's what we will do when rendering GEF4 geometries (which are completely based on double-precision) within a GEF4 Graphics.

Cheers
Alexander

Am 17.04.2013 um 12:16 schrieb Jan Krakora <jan.krakora.cz@xxxxxxxxx>:

Hi all,

since the GEF forum is basically dead I would like to ask you here. Why is used Math.floor in all Precision* classes?

Let me give you an example:

First of all, I use PrecisionPoint, PrecisionRectangle, PrecisionDimension everywhere.

So there is a line with y coordinate 31.14. You have a rectangle with height 18.315 that you would like to draw exactly above the line
so its bottom edge overlaps the line. But since the converting from double to int is done using Math.floor the coordinates
are as such:

the line:
  y: 31.14 -> 31
the rectangle
  y: 31.14 - 18.315 =  12.825 -> 12
  height: 18.315 -> 18

As you can see the rectangle will be rendered above the line. They don't overlap. Why aren't double coordinates rounded?
Do I compute the y of the rectangle in wrong way?

Thanks, Jan Krakora.
_______________________________________________
gef-dev mailing list
gef-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gef-dev

--
Dr. Alexander Nyßen
Dipl.-Inform.
Software-Engineer

Telefon: +49 (0) 231 / 98 60-210
Telefax: +49 (0) 231 / 98 60-211
Mobil: +49 (0) 151 /  17396743

http://www.itemis.de
alexander.nyssen@xxxxxxxxx

itemis AG
Am Brambusch 15-24
44536 Lünen

Rechtlicher Hinweis:

Amtsgericht Dortmund, HRB 20621

Vorstand: Jens Wagener (Vors.), Wolfgang Neuhaus, Dr. Georg Pietrek, Jens Trompeter, Sebastian Neus

Aufsichtsrat: Dr. Burkhard Igel (Vors.), Stephan Grollmann, Michael Neuhaus

_______________________________________________
gef-dev mailing list
gef-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gef-dev

_______________________________________________
gef-dev mailing list
gef-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gef-dev

--
Dr. Alexander Nyßen
Dipl.-Inform.
Software-Engineer

Telefon: +49 (0) 231 / 98 60-210
Telefax: +49 (0) 231 / 98 60-211
Mobil: +49 (0) 151 /  17396743

http://www.itemis.de 
alexander.nyssen@xxxxxxxxx 

itemis AG
Am Brambusch 15-24
44536 Lünen

Rechtlicher Hinweis:

Amtsgericht Dortmund, HRB 20621

Vorstand: Jens Wagener (Vors.), Wolfgang Neuhaus, Dr. Georg Pietrek, Jens Trompeter, Sebastian Neus

Aufsichtsrat: Dr. Burkhard Igel (Vors.), Stephan Grollmann, Michael Neuhaus

_______________________________________________
gef-dev mailing list
gef-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gef-dev