[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [equinox-dev] Gerrit accepts changes w/o Change-Id, is it OK?

If you submit a gerrit without a Change-Id, you can add it with the next update, just add that "Change-Id: I8f3c6f29d2874dbb0f4952d1322150923582f642" to the commit message. Get it fully formatted by pressing the copy button:

Inline images 1

I recommend updating your original gerrit submission and abandoning the second one as the first already has some review done on it.

HTH
Jonah

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com

On 27 January 2018 at 01:25, Mykola Nikishov <mn@xxxxxxxxx> wrote:
Hi,

I just found out that Gerrit accepted a change to project
equinox/rt.equinox.p2 without Change-Id [1] and does not require it [2]
now:

  remote: Processing changes: new: 1, refs: 1, done
  remote: (W) e396989: commit subject >65 characters; use shorter first paragraph
  ...
  remote: The author is not a committer on the project.
  remote: The author has a current Eclipse Contributor Agreement (ECA) on file.
  remote: The author has "signed-off" on the contribution.

As I understand, it makes impossible to submit updates to such change
set.

[1] No Change-Id in https://git.eclipse.org/r/105435
[2] New version of [1] https://git.eclipse.org/r/116165

--
Mykola
https://manandbytes.github.io/

_______________________________________________
equinox-dev mailing list
equinox-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/equinox-dev