[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [equinox-dev] -1 for Mykola Nikishov on rt.equinox by Pascal Rapicault

Stefan, I agree with you on that. I have not been great at helping him and recognizing the problem I've talked to my manager at Ericsson (my current contract) and earlier this week he has agreed to let me spend some time on p2 to help contribs go through.
The other thing that did not help me here is that I never fully understand why so much changes were needed when only SHA256 was required. I think you got some of that context by talking to Mykola and maybe I will need to catch up with you for this.

Pascal

with On 11/15/2016 12:43 PM, Stefan Xenos wrote:
Pascal, if you think he needs more time this is fine. 

However, you'll need to be more responsive regarding his code reviews. The work Mykola has been doing on checksums has been in the review queue for a very long time (some time around May, if I recall) and you are the best subject matter expert for most of the areas it touches.

Please spend some time teaching him what he needs to learn, so we can get the benefit of him as a full committer soon.

The sort of security and privacy concerns that Mykola seems so keen to work on would really benefit the project.

  - Stefan

On Tue, Nov 15, 2016 at 8:37 AM portal on behalf of <portal-noreply@xxxxxxxxxxx> wrote:
Pascal Rapicault voted:
    -1
Mykola has definitely shown tenacity and a strong desire to commit and this
is great.

However I\'m concerned that he is not quite ready because:
- He needs to better grasp the implication of the changes he is proposing
(backward and forward compatibility) and the impact they have on the
overall ecosystem (Tycho, b3, PDE Build, the Platform)
- Some of the changes are causing unnecessary churn in the code
Before giving in the +1, I would like to wait until all the work he is
proposing on SHA256 gets in.

Voting summary: http://portal.eclipse.org/


_______________________________________________
equinox-dev mailing list
equinox-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/equinox-dev


_______________________________________________
equinox-dev mailing list
equinox-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/equinox-dev