[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [equinox-dev] [pde-dev] Repackaging org.osgi.service.component.annotations from Equinox

Hi Tom

Please add that to the bug,

Thanks
Dani



From:        "Thomas Watson" <tjwatson@xxxxxxxxxx>
To:        Equinox development mailing list <equinox-dev@xxxxxxxxxxx>
Date:        04.04.2016 15:10
Subject:        Re: [equinox-dev] [pde-dev] Repackaging        org.osgi.service.component.annotations        from Equinox
Sent by:        equinox-dev-bounces@xxxxxxxxxxx




Equinox will not export the annotation package (via Export-Package) because it will lead to a bad practice of using Import-Package for these non-runtime packages. Whatever the solution ends up being to get the annotations on the classpath of the project, PDE must do so without requiring the bundle manifest to declare a runtime dependency on the annotation package (Import-Package or Require-Bundle).

Tom





From:        
"Daniel Megert" <daniel_megert@xxxxxxxxxx>
To:        
"Eclipse PDE general developers list." <pde-dev@xxxxxxxxxxx>, equinox-dev@xxxxxxxxxxx
Date:        
04/04/2016 04:24 AM
Subject:        
Re: [equinox-dev] [pde-dev] Repackaging org.osgi.service.component.annotations        from Equinox
Sent by:        
equinox-dev-bounces@xxxxxxxxxxx




I don't like that approach which leaves us with maintaining and shipping the same thing twice. Let's continue the discussion in the bug report.

Dani




From:        
Gunnar Wagenknecht <gunnar@xxxxxxxxxxxxxxx>
To:        
"Eclipse PDE general developers list." <pde-dev@xxxxxxxxxxx>
Cc:        
equinox-dev@xxxxxxxxxxx
Date:        
04.04.2016 02:24
Subject:        
Re: [pde-dev] Repackaging org.osgi.service.component.annotations        from Equinox
Sent by:        
pde-dev-bounces@xxxxxxxxxxx




Hi Peter,

I think it's possible for PDE to ship their own jar of the code. You can simply copy the sources from Equinox. I think you still need a CQ, though. It can be a re-use CQ for a subset of the original CQ. Might be easier to jut go with a full re-use.

I've cc'ed equinox-dev because I think this topic may be interesting for them, too.

-Gunnar


--
Gunnar Wagenknecht

gunnar@xxxxxxxxxxxxxxx, http://guw.io/






On 03 Apr 2016, at 14:04, Peter Nehrer <
pnehrer@xxxxxxxxxxxxxxxxxxxxxx> wrote:

Hi,

in order to improve user experience with DS Annotations, I need to contribute package org.osgi.service.component.annotations to PDE projects' classpath (
https://bugs.eclipse.org/bugs/show_bug.cgi?id=488800). This package is already part of Equinox's org.eclipse.osgi.services bundle; however, in order to make these annotations available to external builders, they would need to be in a separate jar (otherwise users would have to place the entire bundle on the build path).

Would it be OK to extract that package from Equinox and provide it via PDE as a separate JAR? Since this isn't new code contribution, do I need any special permissions/process? Thanks!

--Peter
_______________________________________________
pde-dev mailing list

pde-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/pde-dev
_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/pde-dev
_______________________________________________
equinox-dev mailing list
equinox-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/equinox-dev
_______________________________________________
equinox-dev mailing list
equinox-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/equinox-dev