[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [equinox-dev] Merge of equinox committer groups

OK, to be clear Pascal and Ian.  You are fine moving forward with a single committer group for all of Equinox including p2?

Personally I don't see any issues here with merging.  We should be using gerrit reviews, especially if a committer is touching code they are not familiar with.

Tom





From:        Pascal Rapicault <pascal@xxxxxxxxxxxxx>
To:        Equinox development mailing list <equinox-dev@xxxxxxxxxxx>
Date:        03/24/2016 10:10 PM
Subject:        Re: [equinox-dev] Merge of equinox committer groups
Sent by:        equinox-dev-bounces@xxxxxxxxxxx




Well, why not.

On 16-03-22 09:50 PM, Ian Bull wrote:

+1

Cheers,
Ian

On Tue, Mar 1, 2016 at 8:46 AM, Raymond Auge <raymond.auge@xxxxxxxxxxx> wrote:
+1

- Ray

On Tue, Mar 1, 2016 at 10:31 AM, Thomas Watson <tjwatson@xxxxxxxxxx> wrote:
I have no objections to merging in p2.  But I would like Pascal and other p2 committers to agree first.

Tom





From:        
Stefan Xenos <sxenos@xxxxxxxxxx>
To:        
Equinox development mailing list <equinox-dev@xxxxxxxxxxx>
Date:        
03/01/2016 08:25 AM
Subject:        
Re: [equinox-dev] Merge of equinox committer groups
Sent by:        
equinox-dev-bounces@xxxxxxxxxxx





I strongly agree. In fact, I'd go farther and merge in p2 as well. Fragmenting the permissions encourages developers to work around problems in the code they have commit rights to rather in the place where the fix really belongs, and makes it unnecessarily hard to do large changes such as rolling with deprecations.

+1


On Tue, Mar 1, 2016, 5:51 AM Martin Lippert <
mlippert@xxxxxxxxx> wrote:
+1

Cheers,
-Martin


> Am 01.03.2016 um 14:49 schrieb Thomas Watson <
tjwatson@xxxxxxxxxx>:
>
> Right now the equinox project has the following sub-projects, each with their own committer groups
>
> rt.equinox - parent project, no real code here, but it does contain the website
> rt.equinox.framework - where the OSGi framework and Equinox native launcher lives
> rt.equinox.bundles - where everything else is, besides p2
> rt.equinox.p2 - where p2 is
>
> I plan to request the foundation fold rt.equinox.framework and rt.equinox.bundles into the parent project rt.equinox.  I do not think there is a need to separate committers of the various equinox bundles from committers of the framework/launcher or the website.  I do not plan to request p2 be folded into rt.equinox unless the existing p2 community of committers request that to happen.  p2 is a fairly large codebase so it makes sense to keep it separate if the committers want that.  But the rest of Equinox is not that large and maintaining 3 separate committer groups is not worth it in my opinion.
>
> Committers, please voice your concerns if you have them.
>
> Tom
>
>
> _______________________________________________
> equinox-dev mailing list
>
equinox-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>
https://dev.eclipse.org/mailman/listinfo/equinox-dev

_______________________________________________
equinox-dev mailing list

equinox-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/equinox-dev_______________________________________________
equinox-dev mailing list

equinox-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/equinox-dev


_______________________________________________
equinox-dev mailing list

equinox-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/equinox-dev



--
Raymond Augé (@rotty3000)
Senior Software Architect Liferay, Inc. (@Liferay)
Board Member & EEG Co-Chair, OSGi Alliance (@OSGiAlliance)

_______________________________________________
equinox-dev mailing list

equinox-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/equinox-dev



--
R. Ian Bull | EclipseSource Victoria | +1 250 477 7484
http://eclipsesource.com| http://twitter.com/eclipsesource


_______________________________________________
equinox-dev mailing list
equinox-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/equinox-dev
_______________________________________________
equinox-dev mailing list
equinox-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/equinox-dev