[equinox-dev] Huge performance loss between Kepler and Luna/Mars on firs

[Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx>]

Hi,

I've been with a customer today who wants to update from Eclipse 3.x
Kepler to the 4.x code base and so he naturally inherits the latest
Equinox implementation who has changed in between those releases.

The intial boot time increased from about 2 seconds to ~20 seconds on
Mars (on Luna Equinox or better said Felix-Resolver crashes).

We profiled the bootstrap process and the whole time (95%) is eaten up
the by felix resolver ResolverImpl#mergeCandidatePackages

Looking at tbe hot methods we see:
* 15% of the time is spend in ArrayList.contains()

* 30% of the time in HashMap.getNode()
  - called from ResolverImpl#mergeCanidatePackages 7%
  - called from ResolverImpl#calculateExportedPackages 5%
  - called from ResolverImpl#mergeUses 5%

Looking Allocation counts we see the biggest amount (1.9GB) being caused
by ArrayList.grow where we could track back 1.84GB to
mergeCandidatePackages once more which suggests that the initial sizes
choosen for the arrays there are probably not optimal.

One very interesting to this piece of software is that it uses:
a) only require bundle - not very unnatural for Eclipse apps
b) a loooot of reexports!


Would it be possible to:
a) replace the lists through sets? This should improve the contains check
b) use better initial array sizes?

Tom

-- 
Thomas Schindl, CTO
BestSolution.at EDV Systemhaus GmbH
Eduard-Bodem-Gasse 5-7, A-6020 Innsbruck
http://www.bestsolution.at/
Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck