[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [equinox-dev] possible regression in equinox

What's more is that we actually used this not only for equinox, but also for other osgi bundles using framework properties (and also relied on the null state).

- Ray


On Wed, Jul 30, 2014 at 10:57 PM, Raymond Auge <raymond.auge@xxxxxxxxxxx> wrote:
Hey all,

I think I found a regression in equinox when using the framework API.

:(

The scenario is quite simple to reproduce.

java.util.ServiceLoader<FrameworkFactory> loader = java.util.ServiceLoader.load(FrameworkFactory.class);
Map<String, String> properties = new HashMap<String, String>();
properties.put("blah", null);
Framework newFramework = loader.iterator().next().newFramework(properties);

// fails with NPE

This would work fine in every previous version of equinox.

Rationale
So, this might sounds like it's a silly thing to want to do in the first place.Â

However, one very good reason for this is because it's the only way to "set" (or rather "unset") certain equinox flags due to the fact that the only check causing them to be unset is a null check (which if I can't set it null will obviously never be the case).

Again, before Luna, this always worked.

--
Raymond AugÃÂ(@rotty3000)
Senior Software Architect
Liferay, Inc.Â(@Liferay)





--
Raymond AugÃÂ(@rotty3000)
Senior Software Architect
Liferay, Inc.Â(@Liferay)