[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [equinox-dev] [prov] support for separated source bundles released

Thanks for the detail. I think we need to explore a little more the writing, reading and use of this file. I agree completely that the information is needed and that it should be kept separate from the runtime information. Perhaps this is a topic for the p2 call tomorrow?

Re: naming. yes, just "bundles" would be unfortunate. Something like bundles.config gives us the flexibility both in form and content. As for API-ness I agree but if later we want to make it a binary file (for example) we'll have one of two regrettable situations: a binary file called .txt or another file called something other than bundles.txt. The more we can do now to reduce/eliminate the surfacing of our assumptions in things like filenames, the more flexibility we will have tomorrow.

Add artifacts.xml and content.xml to the list of names to reconsider. The .xml adds no value. Something like .index or .si (simple index) would give us the flexibility.

Jeff


Pascal Rapicault wrote:
The file is written by the eclipse touchpoint as a result of a particular
command. In the future I could see it being edited by another command /
party should we decide to list in here the source for other things than
bundles.
The file is read by update.core (for compatibility) and by pde. Initially I
wanted to store it in a folder org.eclipse.pde (under the config area), but
since it was also used by update I found it a new home.
I did not want to store it in org.eclipse.equinox,simpleconfigurator
because this file is not managed by the simpleconfigurator and it is not a
runtime artifact. Source.bundle happens to have the same format than the
bundles.txt because it carries similar information and I did not want to
invent yet another file format. That said this is an implementation detail
and could well change before we ship depending on the people consuming it
needs

As for changing the name of bundles.txt to just bundles, I'm not a big fan
of droping the extension because then it makes it hard to talk about the
file (e.g Do you have all your bundles in the bundles file), however I
don't care about changing it to something else (e.g. list) if someone
provides a patch. We also have to remember that this file is not API and is
completely managed by p2.

PaScaL


equinox-dev-bounces@xxxxxxxxxxx wrote on 02/03/2008 03:08:28 PM:

Thanks Pascal.

As for location, where does it go now?  Who writes it?  Who reads it?
I'm not suggesting it should be beside bundles.txt but am curious to
know why it should not be there?  Colocation seems logical on the
surface (and depending on the answer to the questions above).

As for naming, bundles.txt should just be "bundles"  The fact that it
currently happens to be a text file is implementation detail that may
change over time.  Correspondingly, the source.bundles.txt should likely
just be source.bundles

Jeff

Pascal Rapicault wrote:
PDE is "la raison d'etre" of this support. When we decided to no longer
add
the source bundles to the bundles.txt (a week or so ago), PDE could not
find the source bundles any more since the content of its target is
solely
derived from the bundles.txt. Therefore PDE needed an extra place to
get
the information from and this is what this file provides.
It is only after consultation with Darin and Curtis that we decided to
proceed down this path.

The other consumer of this information is update manager, since in a
co-existence mode where source bundles do not get installed in the fwk,
Update shows errors in the configuration dialog.

Note that I'm open to put the file somewhere else and give it another
name,
except merging it with bundles.txt or putting it next to it.

PaScaL




From: Jeff McAffer <jeff@xxxxxxxxx>



To: Equinox development mailing list <equinox-
dev@xxxxxxxxxxx>



Date: 01/30/2008 07:04 PM



Subject: Re: [equinox-dev] [prov] support for separated
source bundles released






does this affect PDE at all when targetting something installed using p2? That is, do you still get the source in the IDE ?

Jeff

Pascal Rapicault wrote:

Earlier today I have released support to ensure that the source
bundles
would not get added to the bundles.txt (and therefore not installed in

the

runtime).
This support also manages a new file containing all the source bundles

for

the a given installation. This file is located
<install>/configuration/org.eclipse.source.bundles/source.bundles.txt
and
will be used by PDE and some update manager in co-existence mode.

PaScaL

_______________________________________________
equinox-dev mailing list
equinox-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/equinox-dev


_______________________________________________
equinox-dev mailing list
equinox-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/equinox-dev


_______________________________________________ equinox-dev mailing list equinox-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/equinox-dev

_______________________________________________
equinox-dev mailing list
equinox-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/equinox-dev

_______________________________________________
equinox-dev mailing list
equinox-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/equinox-dev