[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [equinox-dev] optimizers, tests and temp files

This folder is created there since this is the default value of the agent
data area when selfhosting. The workaround is to set
-Declipse.p2.data.area. This is being discussed in bug report
https://bugs.eclipse.org/bugs/show_bug.cgi?id=209069




                                                                                                                             
  From:       David R Stevenson <dstevens@xxxxxxxxxx>                                                                        
                                                                                                                             
  To:         Equinox development mailing list <equinox-dev@xxxxxxxxxxx>                                                     
                                                                                                                             
  Date:       11/12/2007 09:14 PM                                                                                            
                                                                                                                             
  Subject:    Re: [equinox-dev] optimizers, tests and temp files                                                             
                                                                                                                             






I synchronized mid-afternoon today and IF I cleanup after the previous run,
then the only failing tests I have are the two that Stefan is working on:

org.eclipse.equinox.p2.tests.artifact.optimizers.jbdiff.JBDiffZipStepTest
org.eclipse.equinox.p2.tests.artifact.processor.jbdiff.JBPatchZipStepTest

Cleanup means:  there is a p2 subdirectory of the eclipse instance I am
running. Delete the three subdirectories, eg:

C:\eclipse\3.4M3\eclipse\p2\org.eclipse.equinox.p2.core
C:\eclipse\3.4M3\eclipse\p2\org.eclipse.equinox.p2.director
C:\eclipse\3.4M3\eclipse\p2\org.eclipse.equinox.p2.engine

If these directories (and presumably the install registry/other kruft left
by the previous run) are present, then an additional 11 director tests
fail.

I agree heartily that each junit or interconnected group of junits should
clean up after, and possibly before, itself.

        - Dave



                                                                           
 Jeff McAffer <Jeff_McAffer@xxxxxxxxxx>                                    
 Sent by:                                                                  
 equinox-dev-bounces@xxxxxxxxxxx                                        To 
                                                  equinox-dev@xxxxxxxxxxx  
                                                                        cc 
 11/12/2007 05:53 PM                                                       
                                                                   Subject 
                                                  [equinox-dev]            
            Please respond to                     optimizers, tests and    
     Equinox development mailing list             temp files               
        <equinox-dev@xxxxxxxxxxx>                                          
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           






I just committed another refactoring of the repo optimizers along with an
improved version of the JarDelta optimizer and some basic tests.  We should
have well optimized repos now! (next step is to pack the jar deltas!!)

In runnig the tests before committing there appear to be 11 of the Director
tests failing.  I did not do anything in this area so assume that they were
failing before this new code came along?  What is our policy on failing
tests?  I've been commenting out my tests that fail until they can be
fixed.  Others?

A number of tests use the TestMetadataRepository mechanism.  This is cool
but unfortunately it leaves temp files down in Documents and Setting
(Windows) at a pretty high rate (~30 per full test run).  There are a few
other files being left around.  We should ensure that our tests run and
clean up after themselves.  In the optimizer tests I've taken to naming the
files and dirs something related to the name of the test (e.g.
p2.optimizers.xxx) so that people encountering these files (leftover from
crashed test runs etc) know what they are.  Do others think this to be a
good idea?

Related to this, we are all likely struggling to setup various repos etc
temporarily for tests and inevitiably using different approaches.  Would it
be worth spending a bit of time creating some test repo infrastructure,
documenting this on the wiki (or wherever) and then making the tests
consistent?  Most of the time I spend on this little project was in
managing all the test code and updating multiple copies.  Taht is, until I
refactored to eliminate duplicate code.  Now the test read well and are
very easy to create.  Easy to create tests => more tests => better code...
Thoughts?

Jeff_______________________________________________
equinox-dev mailing list
equinox-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/equinox-dev
_______________________________________________
equinox-dev mailing list
equinox-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/equinox-dev