[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [equinox-dev] Equinox Aspects CachingService

> Hi Matthew, Martin and all other Equinox Aspects freaks,
> 1. I doubt that caching can be implemented using
> ClassLoadingStatsHook.recordClassDefine() like in AspectJHook.
> ClasspathManager.findClassImpl() calls recordClassDefine() with the
> orignial byte[], not with the woven one. Therefore
> ICachingService.storeClass() will be passed the useless original byte[],
> weaving will not be cached.
> I suggest placing the caching calls into AspectJHook.processClass()
> after the weaving calls.

This has been fixed by https://bugs.eclipse.org/bugs/show_bug.cgi?id=167824
in 3.2.2.  What version of Eclipse are you testing?  The correct
woven bytes are now passed to recordClassDefine.