[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [equinox-dev] JSP support in the servlet bridge incubator project


Harald

> Sounds like you are avoiding a circular reference here.

My approach was to be as unobtrusive as possible. With the fragement bundle I was able to attach the jasper bundle without having to add anything to the org.eclipse.equinox.servlet.bridge.http bundle manifest. I felt that the jasper bundle should be able to be added only if jsp support is required. With some minor changes to some of the code in org.eclipse.equinox.servlet.bridge.http this should be possible.

> Does this mean that you are exposing the servlet api through the
> org.eclipse.equinox.servlet.bridge.extensionbundle bundle?
>
> If yes, wouldn't it make more sense to expose them through the
> org.eclipse.equinox.servlet.bridge.http bundle?


The modification of the the org.eclipse.equinox.servlet.bridge.extensionbundle only comes into play when running this within a WebContainer. If you are using this in a OSGi framework directly then there is only the need for a running bundle to export these packagages.

> Wouldn't it make sense to register the JSPs in the same way?

Yes JSP could be registered in the same way but my own usage pattern seemed to fall into more treating JSP's as extended resources so using the current resource alias extension pont was a better solution.

Richard



Harald Niesche <harald@xxxxxxxxxxxxxxxxxxx>
Sent by: equinox-dev-bounces@xxxxxxxxxxx

06/02/2006 03:40 AM

Please respond to
Equinox development mailing list <equinox-dev@xxxxxxxxxxx>

To
Equinox development mailing list <equinox-dev@xxxxxxxxxxx>
cc
Subject
Re: [equinox-dev] JSP support in the servlet bridge incubator project





Richard Backhouse wrote:
> I felt that instead of having
> to prefix all my JSP requests with "/jasper-jsp" it would be preferable
> to support JSP's just as requests for static resources are handled.

Sounds nice!

> 1.) Created a org.apache.jasper bundle containing the required Jasper
> jars to run the JSP Container (commons-el.jar, jasper-compiler.jar,
> jasper-compiler-jdt.jar and jasper-runtime.jar). This bundle is also a
> fragment bundle whose bundle host is
> org.eclipse.equinox.servlet.bridge.http bundle. This allows references
> to the Jasper classes to be made without having to add explicit imports
> to the org.eclipse.equinox.servlet.bridge.http manifest.

Sounds like you are avoiding a circular reference here.

> The manifest for the
> org.eclipse.equinox.servlet.bridge.extensionbundle was also modified to
> filter the javax.servlet.jsp classes down from the running webcontainer.

Does this mean that you are exposing the servlet api through the
org.eclipse.equinox.servlet.bridge.extensionbundle bundle?

If yes, wouldn't it make more sense to expose them through the
org.eclipse.equinox.servlet.bridge.http bundle?

> to be created as standard OSGi bundles. They register their provided
> TLD's via a TldProvider service I added to the
> org.eclipse.equinox.http.registry bundle.

Wouldn't it make sense to register the JSPs in the same way?

> Thoughts ?

Having no fixed prefix like "/jasper-jsp/" sounds great but I wonder if
this approach can be extended to work with any HttpService. I believe
several people here said they liked  to test their bundles in a
standalone OSGi runtime using either the Jetty-based HttpService or the
Equinox HttpService while deploying using the bridge servlet.

For me it would actually be a requirement that I retain the freedom to
choose which HttpService is used.

Harald

_______________________________________________
equinox-dev mailing list
equinox-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/equinox-dev