| [epp-dev] Consistent i18n in branding plugins |
Hi fellow EPP maintainers, a while back I asked about the naming convention (if any) when externalizing Bundle-Vendor/Bundle-Name [1], as I stumbled upon several inconsistencies when attempting to fix bug 498145 [2]. As my initial mail to epp-dev didn't get any replies, I went ahead and prepared a change [3] that uses OSGI-INF/l10n/bundles.properties for i18n throughout. It also fixes the bug and improves consistency by using the name of the package 1. as the Bundle-Name of the branding plugin's MANIFEST.MF. 2. as the product/@name in the .product file. I someone wants "their" package to *not* follow this set of common conventions, please speak up -- or, better yet, comment in Gerrit [3]. @Markus: If no one wants to stray from these conventions, can you merge the change within the next few days? (I'm reluctant to give it a +2 myself, although I technically could.) Best wishes, Andreas [1] <http://dev.eclipse.org/mhonarc/lists/epp-dev/msg04228.html> [2] <https://bugs.eclipse.org/bugs/show_bug.cgi?id=498145> [3] <https://git.eclipse.org/r/#/c/81283/> -- Codetrails GmbH The knowledge transfer company Robert-Bosch-Str. 7, 64293 Darmstadt Phone: +49-6151-276-7092 Mobile: +49-170-811-3791 http://www.codetrails.com/ Managing Director: Dr. Marcel Bruch Handelsregister: Darmstadt HRB 91940
Attachment:
signature.asc
Description: OpenPGP digital signature