Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [emfindex-dev] API Changes

Hi Knut,

Sven has incorporated the builder functionality into Xtext HEAD, so the EMF Index builder is obsolete. That's why there is no more need to register a resource indexer for automatic indexing. Instead, the indexing is configured in the corrsponding Xtext services.

Most of the functionality of the resource indexer is still there in an default implementation specific class ResouceIndexerImpl, but AFAIK it is not yet used in Xtext.

Does that answer your question?

Best regards
Jan


Am 07.10.2009 um 10:01 schrieb Knut Wannheden:

Hi Jan,

It seems like you've also dropped the resourceIndexer extension point
and corresponding registry. I don't quite understand how this is
supposed to work now. Can you elaborate on this?

Regards,

--knut

On Fri, Oct 2, 2009 at 15:14, Jan Köhnlein <jan.koehnlein@xxxxxxxxx> wrote:
Hi all,

yesterday, I committed a number of changes that also affect the API. This is
what I did

*API vs reference implementation*
I moved everything apart form the api and base source folders into a
separate plug-in in order to better distinguish between API and reference implementation. This should make it easier to add other implementations. Query SPI ha been moved to the reference implementation, too, as it is
considered an implementation detail of the reference impl.
In Xtext, we have to separately index EObjects and EReferences. We have also developed a special (pluggable) builder for that purpose. That made me move
the ResourceIndexer to the reference implementation, too.

*API cleanup*
I removed some classes / parts that were not referenced, i.e.
TransactionException. We should try to avoid putting things in the API we
don't need yet. Please complain if you need one of these classes.
I also completely removed the event API. In Xtext, we're currently using workspace resource listeners (an eclipse builder) and we are happy with these coarse-grained events. We can add it later on once we have clear
requirements.

*Descriptor*
The EObjectDescriptor now has a convenience method createProxy() which
allows to create an EMF proxy.
UserData is now a String to String map. Serializable sounds like a pretty bad idea to me, as the EFactory converts it to/from String anyway. Anybody
who needs this should take care about string conversion themselves.

*Index Updater*
The most serious changes are in the IndexUpdater API. We decided to switch to a less OO-like interface here, which should better suit the needs of SAP.

Feel free to comment.

Best regards
Jan

--
Dr. Jan Köhnlein
Senior Software Architekt

Telefon: +49 (0) 431 / 5606-337
Mobile: +49 (0) 151 / 17396687
Telefax: +49 (0) 431 / 5606-339

http://www.itemis.de
jan.koehnlein@xxxxxxxxx

itemis AG
Niederlassung Kiel
Schauenburgerstr. 116
24118 Kiel
http://www.itemis.de/

Rechtlicher Hinweis:
Registergericht: Amtsgericht Dortmund HRB 20621
Sitz der Gesellschaft: Lünen
Vorstand: Wolfgang Neuhaus, Jens Wagener, Dr. Georg Pietrek
Aufsichtsrat: Prof. Dr. Burkhard Igel (Vorsitzender), Stephan Grollmann,
Michael Neuhaus

_______________________________________________
emfindex-dev mailing list
emfindex-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/emfindex-dev

_______________________________________________
emfindex-dev mailing list
emfindex-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/emfindex-dev

--
Dr. Jan Köhnlein
Senior Software Architekt

Telefon: +49 (0) 431 / 5606-337
Mobile: +49 (0) 151 / 17396687
Telefax: +49 (0) 431 / 5606-339

http://www.itemis.de
jan.koehnlein@xxxxxxxxx

itemis AG
Niederlassung Kiel
Schauenburgerstr. 116
24118 Kiel
http://www.itemis.de/

Rechtlicher Hinweis:
Registergericht: Amtsgericht Dortmund HRB 20621
Sitz der Gesellschaft: Lünen
Vorstand: Wolfgang Neuhaus, Jens Wagener, Dr. Georg Pietrek
Aufsichtsrat: Prof. Dr. Burkhard Igel (Vorsitzender), Stephan Grollmann, Michael Neuhaus



Back to the top