Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] Push branch dialog

Nevermind. I figured it out:
https://github.com/eclipse/egit/commit/1d4628f2f2859e3f5e7473cb6d864f5c29e07ee5

It's an improvement for some user while totally destroying/ignoring the effectiveness of EGit for others. Can we please stop doing this? In common UI workflows without larger impact analysis makes people loose trust in the tools they use every day.

Frankly, this feature was working very well before. It would only bring up the dialogue if push to upstream was not properly configured.

-Gunnar

-- 
Gunnar Wagenknecht
gunnar@xxxxxxxxxxxxxxx, http://guw.io/


> On Jun 15, 2020, at 20:37, Gunnar Wagenknecht <gunnar@xxxxxxxxxxxxxxx> wrote:
> 
> 
> 
> -- 
> Gunnar Wagenknecht
> gunnar@xxxxxxxxxxxxxxx, http://guw.io/
> 
> 
>> On Jun 15, 2020, at 19:39, Thomas Wolf <thomas.wolf@xxxxxxxxxx> wrote:
>> 
>> 
>>> On 15 Jun 2020, at 18:55 , Gunnar Wagenknecht <gunnar@xxxxxxxxxxxxxxx> wrote:
>>> 
>>> I tried 2020-06 RC2 today. I noticed that I am getting the push branch dialog every time now when using cmd+enter in the Staging view. Is this intentional?
>> 
>> No, it isn't. I cannot reproduce this with 2020-06 RC1 and EGit 5.8.0.202006091008-r.
>> Cmd-Enter (or rather, Cmd-Return for me on my Mac) still only commits, and doesn't push.
> 
> Sorry, my bad. I messed up the shortcut. I was referring to the Commit and Push action. In previous versions and was immediately pushing to origin. Now it brings up the push dialog every single time.
> 
> -Gunnar



Back to the top