Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] Two EGit usability enhancements

Looks IMHO way better. Thanks Wim and Matthias.

Best regards, Lars

On Tue, Feb 7, 2017 at 2:58 PM, Wim Jongman <wim.jongman@xxxxxxxxx> wrote:
Inline image 2




On Tue, Feb 7, 2017 at 2:52 PM, Wim Jongman <wim.jongman@xxxxxxxxx> wrote:
Thanks for taking the JGit change. I have fixed the UI. Works nice.

https://git.eclipse.org/r/#/c/90535/

On Tue, Feb 7, 2017 at 12:26 AM, Matthias Sohn <matthias.sohn@xxxxxxxxx> wrote:
On Mon, Feb 6, 2017 at 8:56 PM, Wim Jongman <wim.jongman@xxxxxxxxx> wrote:


I think it would be better to always create a valid branch name and to
remove the checkbox.


Matthias should we get rid of that? It means that some characters that were otherwise valid will not be able to go in the branch name anymore. No big loss if you ask me.


we could avoid this loss if we change Repository.normalizeBranchName(String name) to first check if the passed
is already a valid ref, see https://git.eclipse.org/r/#/c/90474

I think it's ok to remove the checkbox if we accept already valid branch names.

-Matthias



_______________________________________________
egit-dev mailing list
egit-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/egit-dev



--
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com

Back to the top