[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [egit-dev] Expose some internal Page classes to public
|
None of these are public API.
While one can ignore the accessibility warnings, all of these are x-internal only, and we do not guarantee that they don't change. In fact, according to its MANIFEST.MF, EGit UI has no public API at all. A few select packages are made accessible to a few select other bundles via x-friends.
On Jul 13, 2016, at 20:37, Andrey Loskutov wrote:
> The best way to get things done is go create an enhancement request and push a Gerrit patch with the proposed solution.
> The simple reason not to have classes public is that they are internal and used only in that one package.
> See also http://wiki.eclipse.org/EGit/Contributor_Guide
>
>
> Am 13. Juli 2016 20:32:47 MESZ, schrieb "Zhang, Zhaoxi" <zhaoxiz@xxxxxxxxxx>:
>> Ping. Anyone can take a look at this?
>>
>> - Zhaoxi
>>
>> On Jul 12, 2016, at 11:27 AM, Zhang, Zhaoxi
>> <zhaoxiz@xxxxxxxxxx<mailto:zhaoxiz@xxxxxxxxxx>> wrote:
>>
>> Hello everyone,
>>
>> I’m a developer from Amazon. I’m wondering if there is anyway you can
>> expose these following Page classes to public:
>>
>> * org.eclipse.egit.ui.internal.clone.SourceBranchPage
>> * org.eclipse.egit.ui.internal.clone.CloneDestinationPage
>>
>> I found the following Page classes are public already which I will use
>> as well.
>>
>> * org.eclipse.egit.ui.internal.clone.GitProjectsImportPage
>> * org.eclipse.egit.ui.internal.clone.GitSelectWizardPage
>> * org.eclipse.egit.ui.internal.clone.GitCreateGeneralProjectPage
>>
>> Are there any specific reasons you don’t expose the package protected
>> classes? If by no means, you will expose these pages, are there any
>> alternatives for me to reuse these Pages? Thank you.
>>
>> - Zhaoxi
>>
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> egit-dev mailing list
>> egit-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/egit-dev
>
> --
> Kind regards,
> Andrey Loskutov
>
> http://google.com/+AndreyLoskutov
> _______________________________________________
> egit-dev mailing list
> egit-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/egit-dev
