Re: [egit-dev] Conditional request behaviour

[Denis Yuen <Denis.Yuen@xxxxxxxxxx>]

Hi,
Thanks for the heads-up. I'm not sure I have the bandwidth to tackle this soon, but I'll give it a shot if I get a chance. 

Taking a quick look, it looks like Apache HttpClient used to be part of egit but was stripped out for compatibility with Android back in 2011. Do you happen to know off-hand if this is still a concern today? https://github.com/eclipse/egit-github/commit/ca40854c3794b7e720e9d3762c3bbd45c5674c9b

---

From: Matthias Sohn [matthias.sohn@xxxxxxxxx]
Sent: March 21, 2016 5:18 PM
To: Denis Yuen
Cc: egit-dev@xxxxxxxxxxx
Subject: Re: [egit-dev] Conditional request behaviour

On Tue, Mar 15, 2016 at 4:50 PM, Denis Yuen <Denis.Yuen@xxxxxxxxxx> wrote:

Hi,

We're currently using org.eclipse.egit.github.core to talk to the GitHub api as part of an application.
Is there any way in this library to make use of conditional requests https://developer.github.com/v3/#conditional-requests to reduce the number of requests that we're making?

e.g. when using the ContentsService http://javadox.com/org.eclipse.mylyn.github/org.eclipse.egit.github.core/2.1.4/org/eclipse/egit/github/core/service/ContentsService.html is there any way to request ETag values or to set the "If-None-Match" or "If-Modified-Since" headers?

currently org.eclipse.egit.github.core is using HttpURLConnection to execute HTTP requests which doesn't provide caching.

A possible solution to fix this could be to port this bundle to use Apache httpclient instead which provides a caching implementation

see https://hc.apache.org/httpcomponents-client-4.5.x/tutorial/html/caching.html

Maybe you are interested to contribute that ?

-Matthias