Re: [egit-dev] Allow to always use blocks for if/while/for/do statements

[Robin Stocker <robin@xxxxxxxxx>]

+1. It's a waste of time and energy on reviews.

And yes, it's inconsistent which prevents use of the formatter and
save actions, see this change and referenced ones:

https://git.eclipse.org/r/#/c/5753/

Cheers,
  Robin

> I'd like to voice a big +1 on this... This rule is painful and not
> even
> consistent (do not use a block on single-line if, except if the
> content
> is too big... in which case use a block even if it's a single line).
> I'd
> argue that something the formatter cannot do alone is not a good
> practice...
> 
> Laurent
> 
> On 13/01/2015 00:07, Andrey Loskutov wrote:
> > Hi,
> >
> > I was many times beaten during the reviews of my patches to j/egit
> > projects
> > because I always use blocks for all if/while/for/do statements,
> > independently
> > of their size, but j/egit coding style says "no braces should be
> > used for one-
> > line statements" [1].
> >
> > So this is OK for j/egit:
> >
> > if(bla)
> >    doSomething();
> >
> > but this is NOT:
> >
> > if(bla){
> >    doSomething();
> > }
> >
> > I found this rule pretty annoying for many reasons: the rule itself
> > is not
> > only an exception from the general rule to have braces around any
> > blocks but
> > also contains another 2 exceptions that you *have to* use braces in
> > some
> > special cases. The code containing multiple if/else block with and
> > without
> > braces looks inconsistent, refactoring often leads to left-over
> > braces.
> > Especially that Eclipse formatter does not remove "unnecessary"
> > braces
> > automatically is kind of showstopper - one can't even trust
> > Ctrl+Shift+F :-).
> >
> > Is there any strong reason to keep this rule or is it just matter
> > of taste?
> >
> > Can we please relax the guidelines and remove this rule from the
> > coding
> > guidelines?
> >
> > [1]
> > https://wiki.eclipse.org/EGit/Contributor_Guide#Braces_for_one-line_statements