| Re: [egit-dev] Let's debate about "Commit and Push" behaviour |
|
Hi, I would also like to see some simple push wizard as in my workflow I quite often use force push (on my topic branch). Current implementation makes "Commit & push" button unusable for me. Radim
On Wednesday, August 06, 2014 16:15:24 Mickael Istria wrote: > Hi all, > > I'd like to debate with you about something I don't like in "Commit and > Push" action. > Specifically, it's on line 132 of > org.eclipse.egit.ui.internal.commit.CommitJob, in the pushUpstream > method [1]. > > When a push config is already available (push config seem to be created > automatically, and as a user, I don't remember I specifically created > one; and I don't know much how they are created), it gets systematically > used in order to push the new commit. However, it happens *very* often > that I want to push to a custom branch, whatever is my current active > branch. (As I'm using Gerrit and usually pushing singe commits for > review, I don't create topic branch, I switch directly between commits, > so I don't really care about branches and don't manage them cleanly). So > I almost always want to see the Push wizard to specify how I want to > push stuff. > However, in most cases, I don't see this wizard and EGit decides of how > to push stuff, which is almost never what I want to do. > > Instead, I suggest we always show the (simple [2]) push wizard, and use > the push config as initial settings to pre-populate the wizard fields > (it seems to me it's already the current behaviour of the wizard). So > people who are ok with default settings can just push "Finish" and other > ones can perform their tweaks. > This approach would have the benefit of being usable for everyone, the > drawback is that people who are happy with the stored configuration have > 1 more click to do. > > More generally, I would rather always see the Simple Push wizard before > direct push action. > > Do you think my use-case is worth adding a click to some other people? > I'm not sure whether one scenario is much more common than the other. > > Cheers, > > [1] > http://git.eclipse.org/c/egit/egit.git/tree/org.eclipse.egit.ui/src/org/ecli > pse/egit/ui/internal/commit/CommitJob.java#n132 [2] > https://bugs.eclipse.org/bugs/show_bug.cgi?id=441231
|