Re: [egit-dev] Hanging Eclipse

[Matthias Sohn <matthias.sohn@xxxxxxxxx>]

On Thu, Feb 13, 2014 at 8:18 AM, Duft Markus <Markus.Duft@xxxxxxxxxxxxxxxx> wrote:

Hey!

 

Lately I have found my eclipse hanging from time to time (every other minute) for a few seconds. When I look at the stack traces with jstack it looks something like this in the main thread:

 

"main" prio=10 tid=0x00007f42f000a000 nid=0x4040 sleeping[0x00007f42f8a84000]

   java.lang.Thread.State: RUNNABLE

        at sun.security.provider.SHA.implCompress(SHA.java:122)

        at sun.security.provider.DigestBase.engineUpdate(DigestBase.java:133)

        at java.security.MessageDigest$Delegate.engineUpdate(MessageDigest.java:568)

        at java.security.MessageDigest.update(MessageDigest.java:313)

        at org.eclipse.jgit.dircache.DirCacheEntry.<init>(DirCacheEntry.java:170)

        at org.eclipse.jgit.dircache.DirCache.readFrom(DirCache.java:483)

        at org.eclipse.jgit.dircache.DirCache.read(DirCache.java:411)

        at org.eclipse.jgit.dircache.DirCache.read(DirCache.java:194)

        at org.eclipse.jgit.dircache.DirCache.read(DirCache.java:166)

        at org.eclipse.jgit.lib.Repository.readDirCache(Repository.java:1018)

        at org.eclipse.jgit.submodule.SubmoduleWalk.forIndex(SubmoduleWalk.java:95)

        at org.eclipse.egit.ui.internal.staging.StagingViewContentProvider.inputChanged(StagingViewContentProvider.java:321)

        at org.eclipse.jface.viewers.ContentViewer.setInput(ContentViewer.java:276)

        at org.eclipse.jface.viewers.StructuredViewer.setInput(StructuredViewer.java:1690)

        at org.eclipse.egit.ui.internal.staging.StagingView$42.run(StagingView.java:2071)

        at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)

        at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)

        - locked <0x00000007d4fe3770> (a org.eclipse.swt.widgets.RunnableLock)

 

We are not using submodules at all. Is there something wrong? Restarting eclipse most of the time helps me out for a while.

 

This is on 3.2.0 release with eclipse 4.3.1. Does somebody know about this issue already?

I ran blame on StagingViewContentProvider and found that you are the author of the last change

which introduced calling SubmoduleWalk.forIndex   ;-)

As Jens pointed out this should be moved to a background thread.

Can you check the following:

- do you have a .gitmodules file in the root of your working tree ?

- any GITLINK file mode (0160000) in your repositories index ? you may find them by running

  jgit debug-show-dir-cache

  from inside your repository's working tree, the file mode is the first column

--

Matthias