Re: [egit-dev] Request for a review

[Sascha Vogt <FunkyFish@xxxxxxx>]

Hi Matthias,

Am 12.12.2013 14:16, schrieb Matthias Sohn:
> I will try to find time later today to review your change. Preparing
> release of 3.2 
> next Wednesday keeps us already pretty busy hence changes for master
> may have to wait a little longer until someone finds time for review. 
Great, thanks. And no problem with that :) It's basically 2 LOC

> BTW reviews can also be done by non-committers, though a committer has
> to +2 and submit the change to conclude the review successfully.
Is this something EGit wants? I was afraid to add my +1 to something as
I have basically NO idea what standards you're trying to achieve. If
it's ok, I'll try to check 1 or 2 of the simpler ones and give my +1 if
the described commit works (or if it at least works for me ;)

> We assume authors to be responsible to drive their contributions forward,
> often such older reviews are stalled since the author doesn't react on
> review
> comments. Though it happens also that such stale changes are taken up again
> even after sleeping for a longer time. We could abandon those where the
> author
> seems to have gone elsewhere. Maybe I find time for this beginning of
> next year.
I've pinged @cra via Twitter and he immediately abandoned his two. I'll
try that with some of the other older ones, if I find a Twitter handle
from the author, a few names sound familiar ;)

Greetings
-Sascha-