Re: [egit-dev] Request for a review

[Matthias Sohn <matthias.sohn@xxxxxxxxx>]

On Thu, Dec 12, 2013 at 1:27 PM, Sascha Vogt <FunkyFish@xxxxxxx> wrote:

Hi all,

I want to politely ask for a review of
https://git.eclipse.org/r/#/c/19536/

It's a very simple enhancement (strip git clone from a pasted URL, if it
is present). As Gerrit, Gitblit and others add that part when you use
their "copy to clipboard" functions it would be nice if EGit could just
remove them...

I will try to find time later today to review your change. Preparing release of 3.2 

next Wednesday keeps us already pretty busy hence changes for master

may have to wait a little longer until someone finds time for review. 

BTW reviews can also be done by non-committers, though a committer has

to +2 and submit the change to conclude the review successfully.

 

In addition, I would like to know, if there is somebody actively
monitoring open changes which have gone stale? When searching for open
reviews, I found 39 of 76 open reviews have the last update > 1 year. Is
it save to assume, that they no longer apply and could be closed?

We assume authors to be responsible to drive their contributions forward,

often such older reviews are stalled since the author doesn't react on review

comments. Though it happens also that such stale changes are taken up again

even after sleeping for a longer time. We could abandon those where the author

seems to have gone elsewhere. Maybe I find time for this beginning of next year.

--

Matthias