[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [egit-dev] Improvement Suggestions / What's your opinion(s)?
|
On Wed, Nov 6, 2013 at 8:08 AM, Duft Markus <Markus.Duft@xxxxxxxxxx> wrote:
>> -----Ursprüngliche Nachricht-----
>> Von: egit-dev-bounces@xxxxxxxxxxx [mailto:egit-dev-bounces@xxxxxxxxxxx] Im Auftrag von Tomasz Zarna
>> Gesendet: Dienstag, 5. November 2013 21:50
>> An: Robin Rosenberg
>> Cc: EGit developer discussion (egit-dev@xxxxxxxxxxx)
>> Betreff: Re: [egit-dev] Improvement Suggestions / What's your opinion(s)?
>>
>> > Some kind of (Java!) commit “checker”.
>>
>> A similar mechanism, much simpler, is used by the Eclipse CVS client.
>> It allows to abort a commit if resources it contains have warnings or
>> errors [1]. I assume you would like to take one step further.
>
> Ah did not know this, but yes, I'd like to do more :) I'd like this hooks to be free to mess with mostly anything the public APIs can do :) However we (Christian and I) thought about passing in the commit object right /after/ the commit, to avoid passing around internal data structures (DirCache, ...). Hooks can "prevent" the commit by resetting for example. Or change it by amending, ...
I'd suggest also creating 'simple' APIs which allow the extension to
perform some common tasks easily:
1. Rejecting the commit ( with a message being passed to the user )
2. Updating the commit message
This way we won't reinvent the wheel lots of times when writing extensions.
Robert
>
> Cheers,
> Markus
>
>>
>> [1] see the Prompting tab description here:
>> http://help.eclipse.org/kepler/topic/org.eclipse.platform.doc.user/reference/ref-19cvs.htm?cp=0_4_1_16
>>
> [snip]
> [Beschreibung: facebook_icon_signatur]<http://www.facebook.com/SSI.SCHAEFER.DE> [Beschreibung: twitter_icon_signatur] <http://twitter.com/ssi_schaefer_de> [Beschreibung: youtube_icon_signatur] <http://www.youtube.com/user/lagerlogistik1> [Beschreibung: blog_button_signatur] <http://www.ssi-schaefer.de/blog> [Beschreibung: feed_icon_signatur] <http://www.ssi-schaefer.de/news-infocenter/aktuelles/rss.xml>
> --
> Salomon Automation GmbH - Friesachstrasse 15 - A-8114 Friesach bei Graz
> Sitz der Gesellschaft: Friesach bei Graz
> UID-NR:ATU28654300 - Firmenbuchnummer: 49324 K
> Firmenbuchgericht: Landesgericht für Zivilrechtssachen Graz
> _______________________________________________
> egit-dev mailing list
> egit-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/egit-dev
--
http://robert.muntea.nu/
