Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] [jgit-dev] New legal requirements for contributions
I'd also like to add a few questions : what for "contributors" that are also "commiters", but on other projects? I am an Eclipse commiter on EMF Compare and Acceleo. My company (Obeo) is an Eclipse Member company (with a Member commiter agreement if that changes anything). I wish to contribute patches to EGit. This is a use case I found ... not really well explained in the old legal process, and for which I don't really find answers in the new process either.

Do I also have to sign the CLA? Do I also need the Signed-off-by footer entry in my commit messages?

This isn't really specific to EGit, I'd also like to know what I need to ask my coworkers when they need to contribute patches to the projects on which I am a commiter. What to ask to external contributors is well defined, what to ask to other commiters (from other projects), or people from member companies isn't that clear.

Laurent Goubet
Obeo

On 01/07/2013 23:19, Matthias Sohn wrote:



On Mon, Jul 1, 2013 at 5:09 PM, Robin Stocker <robin@xxxxxxxxx> wrote:
> Due to the rollout of Contribution License Agreements by the Eclipse
> Foundation the
> formal rules for contributions changed [1]. I updated the contributor
> guide [2] accordingly.
>
> Committers and contributors: please make yourself familiar with the
> new rules.

Just to make sure:

If a change was pushed to Gerrit after the switch, the only thing that
has to be checked as a committer are copyright headers and whether it
needs a CQ (the magic 200 lines mark).

AFAIK a CQ is needed for initial contributions, patches larger than 250 lines
or containing encryption code [3].
 
In other words, Gerrit rejects the push if the CLA and Signed-off-by
are incorrect. Right?

that's what the last paragraph in [4] states, though I am not sure when
exactly Gerrit will enforce this (in July 2013 isn't a very precise date).
If in doubt committers can check if a contributor has a valid CLA here [5].
 
What about changes that were pushed before the switch? Does Gerrit
reject "Submit" if the information is incorrect or should we ask
contributors to re-push? Or is a rebase through the Gerrit UI enough?

@Wayne: could you answer these questions ?
 
Cheers,
  Nibor

[3] http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf
[4] http://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions
[5] http://projects.eclipse.org/user/cla/validate

--
Matthias


_______________________________________________
egit-dev mailing list
egit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/egit-dev


begin:vcard
fn:Laurent Goubet
n:Goubet;Laurent
org:<a href="http://www.obeo.fr";>Obeo</a>
email;internet:laurent.goubet@xxxxxxx
url:http://www.obeo.fr
version:2.1
end:vcard

Back to the top