Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] Any chance for some feeback on those 2 patches?

Hi Andre,

No one will do a review as long as Hudson is not happy with the
change. If you're 100% sure the failures are not related to your
patch, and the tests pass locally add a comment about it.

@JGit: Haven't looked at the code yet, but does it make sense to add a
test case for the new API you added?

@EGit: There is a special tag for marking EGit changes dependent on
JGit i.e. "JGit-Dependency", please add it to the commit message.

Cheers,
Tomasz

On Fri, Jan 25, 2013 at 10:05 AM, André Dietisheim <adietish@xxxxxxxxxx> wrote:
> Hi!
>
> In order to be able to display server message while we're pushing (like
> screencasted here: https://bugs.eclipse.org/bugs/attachment.cgi?id=225770),
> I did 2 patches for egit and jgit and pushed those to gerrit:
>
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=398387 ->
> https://git.eclipse.org/r/#/c/9730/
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=398404 ->
> https://git.eclipse.org/r/#/c/9732/
>
> Juno SR2is pretty much close ahead, so I'd appreciate a lot if we could get
> some feedback on those?
>
> Thanks!
> André
>
>
> _______________________________________________
> egit-dev mailing list
> egit-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/egit-dev
>


Back to the top