Re: [egit-dev] Missing menu entry in history view (again)

[Matthias Sohn <matthias.sohn@xxxxxxxxx>]

2012/12/16 Robin Rosenberg <robin.rosenberg@xxxxxxxxxx>

----- Ursprungligt meddelande -----

> 2012/12/16 Robin Rosenberg < robin.rosenberg@xxxxxxxxxx >
>
>
>
>
>
>
> ----- Ursprungligt meddelande -----
> > Am 16.12.2012 17:31, schrieb Robin Rosenberg As an illustration
>
> > here
> > are screenshots. The first, longer menu
> > > is from Eclipse 3.7.2 and the other one from 3.8 (same in 4.2).
> >
> > Might be an issue in the platform? If it works on 3.7.2 but not in
> > 3.8.
> > Have you checked for some obscure key binding conflict errors in
> > the
> > log?
>
> CDT complains, but in a pure 3.8.0 installation there was no CDT and
> the issue. I did find that I had some scratch projects that had lost
> their .git directory so I removed a few and things started to work.
> Funnily, I still see the same warnings so it's not that simple.
>
> I'll try to recreate the other workspaces too. Thanks for the help.
>
>
>
> Visibility of these commands depends on selection, for me these menu
> entries are
> shown if a file is selected e.g. in Package Explorer. This works here
> on Mac OS X 10.8.2
> for Eclipse 3.7.2, 4.2.1 and 4.3.0 M3. If a folder is selected or
> without selection these
> menu entries are not shown.

Seems correct. Where is that controlled? Makes sense for the other commands,
but not for the one I missed.

I think this is controlled in the handler classes in package

org.eclipse.egit.ui.internal.history.command

e.g. CompareWithWorkingTreeHandler.isEnabled() 

--
Matthias