[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] EGit UI tests fail on Eclipse 4.2 with java.lang.NoSuchMethodError: org.eclipse.ui.internal.PartPane.getToolBar()Lorg/eclipse/swt/widgets/Control

2012/4/10 Paul Webster <pwebster@xxxxxxxxxxxxxxxxxxx>
On Thu, Apr 5, 2012 at 7:32 PM, Matthias Sohn <matthias.sohn@xxxxxxxxxxxxxx> wrote:
I am trying to make the EGit UI tests run on Eclipse 4.2, I can't get over the following
problem which seems to be caused by SWTBot using the following method of anÂ
internal class org.eclipse.ui.internal.PartPane.getToolBar()
which is no longerÂavailable in 4.2. This affects quite a number of EGit UI tests.

I tried both the Helios and Indigo nightly build versions of SWTBot.
I couldn't find any Juno / 4.2 based SWTBot version.

Any hints how to fix this ?

testCreateCheckoutDeleteLocalBranch(org.eclipse.egit.ui.view.repositories.GitRepositoriesViewBranchHandlingTest) ÂTime elapsed: 3.965 sec Â<<< ERROR!
org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NoSuchMethodError: org.eclipse.ui.internal.PartPane.getToolBar()Lorg/eclipse/swt/widgets/Control;)

They'd need to replace that code with something like:

ToolBar toolbar = null;
IToolBarManager t = ((IViewSite)part.getSite()).getActionBars().getToolBarManager();
if (t instanceof ToolBarManager) {
ÂÂÂ toolbar = ((ToolBarManager)t).getControl();

thanks Paul for your hints :-)

I posted 2 patches to Bugzilla [1] hoping that some SWTBot wizard
finds time to review them. The patches provide build configuration
for 4.2M6 and fix the compile errors. Though running the SWTBot tests
on Mac OSX reveal around 30 errors, looks like there are more problems
on 4.2. Hence I need help from somebody whoÂknows more aboutÂ
SWTBot in order to get an idea what theseÂerrors mean.