[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] staging view and indexing quirks

On 03/09/2012 09:25 AM, Matthias Sohn wrote:
> yes, it looks like there is a problem when deleting branches.
> Yesterday my workbench stopped working after deleting a couple
> of branches (multi-selected) and I noticed by chance that the
> workbench ran more than 1400 threads ...

oh, wow - not so good. i also noticed (since i wrote my own little integration with jgit), that jgit sometimes (when rebasing for example) fires multiple refsChanged events where there would be only one required for the UI to catch up (when rebasing is done; from a jgit POV the behaviour is correct; just EGit would require less events to get the UI right). maybe it's the same thing when deleting branches (refs do change there, right?). possibly just some guards missing in egit?

Regards,
Markus

> 
> --
> Matthias
> 
> 2012/3/9 Kinzler, Mathias <mathias.kinzler@xxxxxxx <mailto:mathias.kinzler@xxxxxxx>>
> 
>     Saw the problem with lots of indexing jobs just yesterday (EGit 1.3.0). I even killed my Eclipse after two or three minutes.  This happened after deleting some branches. Coincided with a flickering History View, so I guess there may be some issue between the History View's refresh and the re-indexing...
> 
>     > -----Original Message-----
>     > From: egit-dev-bounces@xxxxxxxxxxx <mailto:egit-dev-bounces@xxxxxxxxxxx> [mailto:egit-dev-bounces@xxxxxxxxxxx <mailto:egit-dev-bounces@xxxxxxxxxxx>] On
>     > Behalf Of Marc-Andre Laperle
>     > Sent: Donnerstag, 8. März 2012 18:34
>     > To: egit-dev@xxxxxxxxxxx <mailto:egit-dev@xxxxxxxxxxx>
>     > Subject: Re: [egit-dev] staging view and indexing quirks
>     >
>     > On the topic of indexing quirks, I also noticed that when building
>     > projects, a lot indexing jobs can be started for the same repo.
>     > Sometimes the extra ones get cancelled but sometimes they don't and it
>     > then takes forever for all of them to complete. Anyone else seeing that?
>     >
>     > Marc-Andre
>     >
>     > On 08/03/2012 11:12 AM, Markus Duft wrote:
>     > > Hey!
>     > >
>     > > I have made a little change [1] to the staging view. Its still in a "pre-alpha"
>     > stage, so don't expect everything to be perfect. i just need some review and
>     > input whether i'm on the right track.
>     > >
>     > > the story behind the change is, that in our workspace (approx 600 projects
>     > with approx 6 million line of code) the re-indexing of the repo takes ages (speak
>     > ~1 minute on a fast machine). thus we want to as far as possible avoid re-
>     > indexing. the staging view now has it's own indexing job, which runs
>     > independently of the indexDiffCache update jobs (am i wrong here?). i want to
>     > get rid of this, so we can (finally) start using the staging view.
>     > >
>     > > [1] https://git.eclipse.org/r/#/c/5299/
>     > >
>     > > regards, and thanks for the input in advance :D
>     > > Markus
>     > > _______________________________________________
>     > > egit-dev mailing list
>     > > egit-dev@xxxxxxxxxxx <mailto:egit-dev@xxxxxxxxxxx>
>     > > https://dev.eclipse.org/mailman/listinfo/egit-dev
>     >
>     > _______________________________________________
>     > egit-dev mailing list
>     > egit-dev@xxxxxxxxxxx <mailto:egit-dev@xxxxxxxxxxx>
>     > https://dev.eclipse.org/mailman/listinfo/egit-dev
>     _______________________________________________
>     egit-dev mailing list
>     egit-dev@xxxxxxxxxxx <mailto:egit-dev@xxxxxxxxxxx>
>     https://dev.eclipse.org/mailman/listinfo/egit-dev
> 
> 
> 
> 
> -- 
> Matthias
> 
> 
> _______________________________________________
> egit-dev mailing list
> egit-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/egit-dev