[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [egit-dev] Missing refs/notes/review in new repository on Gerrit causes fetch to fail
- From: Sascha Scholz <sascha.scholz@xxxxxxxxx>
- Date: Fri, 13 Jan 2012 14:20:35 +0100
- Delivered-to: firstname.lastname@example.org
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=q+yOYTI7oULnVBon78A6AhNznDaRxAGpApu72sW24AM=; b=j0xZTEWf+/6dFzmpk+xCt0kDvpBZgLslMVaCtEpARetVKuMUH+ZSlZSDYm+cWan9V9 aIKTkARdSUUknq8JiPI2etIQgUBL0+kQqFy+cFcFh6vfhsoYj3mwy04z/ZqJDwhEES5W bVMy0YQo2x3+mJ02b1O+0X02osQ4jZrkhEJaE=
is there already progress in this area? Or should I create a bugzilla
issue for jgit?
On Wed, Dec 21, 2011 at 10:22 AM, Sascha Scholz <sascha.scholz@xxxxxxxxx> wrote:
> On Tue, Dec 20, 2011 at 5:31 PM, Shawn Pearce <sop@xxxxxxxxxx> wrote:
>> EGit should look at the the advertised references to see if
>> refs/notes/review exists before it starts to fetch. If it doesn't,
>> don't ask for it. Maybe it makes senes to add an "ignore missing"
>> option to the JGit RefSpec object type so that EGit can tell JGit its
>> OK if a refs/notes/review reference isn't available for fetch. C Git
>> maybe should learn a syntax like that too, maybe "fetch =
>> ?refs/notes/review:refs/notes/review". I would push this upstream with
>> both C Git and JGit projects and see if we can find a way to make
>> these sorts of fetch specifications non-fatal.
>> Another option is to fetch refs/notes/*:refs/notes/* instead of just
>> the review branch.
> +1 for having the ? prefix in a fetch spec to mark it as optional
> -1 for fetching refs/notes/*. That was the first implementation idea
> and we discarded it because you don't know what other notes may now or
> in future be available (and maybe you don't want to fetch them by