[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [egit-dev] please comment on commit and push 1 interaction
|
Hi Manuel
On 09/17/2011 06:55 AM, Manuel Doninger wrote:
could you push your patches
to the EGit Gerrit Code Review server, according to the Contributor
guide (http://wiki.eclipse.org/EGit/Contributor_Guide)?
We're already reviewing a patch on gerrit
(http://egit.eclipse.org/r/#change,4103,patchset=2). The patch attached
to the bugzilla is obsolete and I just marked it accordingly.
The inputs I was requiring arose in the review on gerrit.
Cheers
André
Regards,
Manuel
On Fri, Sep 16, 2011 at 22:07, André Dietisheim<adietish@xxxxxxxxxx> wrote:
Hi guys
I made some suggestions and was asking for input on
https://bugs.eclipse.org/bugs/show_bug.cgi?id=330048.
1) what push to execute after the commit?
* simple push
* fully fledged push?
Our usecase requires one to be able to push to a special ref which is not
origin. So we would need a fully fledged push where you can indicate the
remote to push to. Since you thought that most users would need a simple
push to origin, let us add 2 checkboxes?
2) have push enabled on each IResource?
Currently the PushActionHandler is only enabled if the project is selected.
I therefore cannot execute the push command if you picked commit while
selecting a file. Some users even whished they would like to be able to pick
"push" (and push the proj) if they select a file in the package explorer. I
could easily change that but I guess that you had good reasons to enable
push on projects only. I'd love to know about these reasons before I go and
switch that activation expression and possibly destroy some usecases.
Thanks
André
_______________________________________________
egit-dev mailing list
egit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/egit-dev
